[
https://issues.apache.org/jira/browse/JENA-1313?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16049629#comment-16049629
]
ASF GitHub Bot commented on JENA-1313:
--------------------------------------
GitHub user afs opened a pull request:
https://github.com/apache/jena/pull/262
JENA-1313: Some cleanup around NodeValueSortKey
- NodeValue.sameAs (complete switch statement)
- Add NodeValue.getSortKey() and use instead of casts.
- javadoc fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/afs/jena sortkey
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/262.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #262
----
commit 11f7ef8b20d21151a0282015d3cda916e73bcf58
Author: Andy Seaborne <[email protected]>
Date: 2017-06-14T20:23:50Z
JENA-1313: Some cleanup
NodeValue.sameAs (complete switch statement)
Add NodeValue.getSortKey and use instead of casts.
javadoc fixes
----
> Language-specific collation in ARQ
> ----------------------------------
>
> Key: JENA-1313
> URL: https://issues.apache.org/jira/browse/JENA-1313
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Affects Versions: Jena 3.2.0
> Reporter: Osma Suominen
>
> As [discussed|http://markmail.org/message/v2bvsnsza5ksl2cv] on the users
> mailing list in October 2016, I would like to change ARQ collation of literal
> values to be language-aware and respect language-specific collation rules.
> This would probably involve changing at least the
> [NodeUtils.compareLiteralsBySyntax|https://github.com/apache/jena/blob/master/jena-arq/src/main/java/org/apache/jena/sparql/util/NodeUtils.java#L199]
> method.
> It currently sorts by lexical value first, then by language tag. Since the
> collation order needs to be stable across all possible literal values, I
> think the safest way would be to sort by language tag first, then by lexical
> value according to the collation rules for that language.
> But what about subtags like {{@en-US}} or {{@pt-BR}}? Can they have different
> collation rules than the main language? It would be a bit strange if all
> {{@en-US}} literals sorted after {{@en}} literals...
> It would be good to check how Dydra does this and possibly take the same
> approach. See the message linked above for further backgound.
> I've been talking with [~kinow] about this and he may be interested in
> implementing it.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
