Github user afs commented on a diff in the pull request:

    https://github.com/apache/jena/pull/271#discussion_r130117735
  
    --- Diff: jena-arq/src/main/java/org/apache/jena/riot/RDFParserBuilder.java 
---
    @@ -504,8 +504,10 @@ private HttpClient buildHttpClient() {
                 Header header = new BasicHeader(k, v);
                 hdrs.add(header);
             });
    -        HttpClient hc = 
CachingHttpClientBuilder.create().setDefaultHeaders(hdrs).build();
    -        return hc;
    +        HttpClient hc = HttpOp.createPoolingHttpClientBuilder()
    --- End diff --
    
    What is required is a builder that is based on another but isolated from it 
by cloning (or in some way) so that adding new builder settings only changes 
the clone, not also the original (the current active default in `HttpOp` in 
this case).`HttpClientBuilder` is a setter only style, you can't get settings 
from it (builder builder needed ?!). `RDFparserBuilder` has `clone()`.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to