[
https://issues.apache.org/jira/browse/JENA-1381?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16134202#comment-16134202
]
ASF GitHub Bot commented on JENA-1381:
--------------------------------------
Github user afs commented on the issue:
https://github.com/apache/jena/pull/274
This adds `NamedGraph` - a graph wrapper that carries around a graph name.
The problem is now that graphs in a general dataset only have an associated
name by virtue of the slot in the map they occupy, unlike ones from a quad
dataset where the graph is a `GrahView`, a restriction of the "G" slot of the
quad to a specific name.
The updated test case on
[JENA-1381](https://issues.apache.org/jira/browse/JENA-1381) shows this - it
tests three kinds of dataset in memory.
| Dataset factory | Implementation | Characteristics | Status (before PR) |
| --------------- | -------------- | --------- | ---- |
| `create()` | `DatasetGraphMap` | Copy-in on add graph | No
graph index |
| `createGeneral()` | `DatasetGraphMapLink` | Link to added graphs | No
graph index |
| TIM | Quads | `getGraph` returns a `GraphView` | OK |
| TDB | Quads | `getGraph` returns a `GraphView` | OK |
**`create()`** : `DatasetGraphMap` can change to use a `NamedGraph` by
changing the `GraphMaker` interface to take a name and then using
`NamedGraphWrapper` aroudn an in-memeory graph.
**`createGeneral()`** : `DatasetGraphMapLink` can either change to return a
`NamedGraph` which mean
the graph returned by `getGraph` is not the graph added, or can remain not
supporting test query graph. The general dataset is already less aligned with
the other implementations and can be considered "special purposes only" -
usually complex mixtures of graph types or inference graphs.
The javadoc for `DatasetFactory` is supposed to discourage use of the
linking `createGeneral`.
The recent commits provide this and update the javadoc in `DatasetFactory`.
> jena-text does not respect graph indexing in the text query cache
> -----------------------------------------------------------------
>
> Key: JENA-1381
> URL: https://issues.apache.org/jira/browse/JENA-1381
> Project: Apache Jena
> Issue Type: Bug
> Components: Text
> Affects Versions: Jena 3.4.0
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
> Attachments: TextIndexReport.java
>
>
> jena-text does not respect the graph setting when using the text query cache.
> In the example attached, the dataset has two graphs; the first result is
> used for the second text query. Depending on the order, either both text
> queries are zero or both one hit when the right answer is zero, once and one,
> once.
> Note also the "graph" feature of jena-text only works with quad based
> datasets (strictly, ones that use GraphView for their graphs). General
> dataset do not. This is hidden in the pattern where there is a test triple
> pattern that the literal is actually in the graph.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
