[
https://issues.apache.org/jira/browse/JENA-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16188492#comment-16188492
]
ASF GitHub Bot commented on JENA-1393:
--------------------------------------
Github user afs commented on a diff in the pull request:
https://github.com/apache/jena/pull/282#discussion_r142207309
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/util/FmtUtils.java
---
@@ -535,6 +535,7 @@ private static boolean validPNameChar(char ch)
{
if ( Character.isLetterOrDigit(ch) ) return true ;
if ( ch == '.' ) return true ;
+ if ( ch == ':' ) return true ;
--- End diff --
If only `switch` accepted `Character.isLetterOrDigit` ... (this is not
`match`!)
> FmtUtils.stringForURI does not compact URIs with ":" in localname
> -----------------------------------------------------------------
>
> Key: JENA-1393
> URL: https://issues.apache.org/jira/browse/JENA-1393
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ, Jena
> Affects Versions: Jena 3.1.1, Jena 3.2.0, Jena 3.3.0, Jena 3.4.0
> Reporter: Michał Woźniak
> Assignee: Andy Seaborne
> Priority: Minor
> Attachments: fix_stringForURI.patch
>
>
> *Issue*: {{FmtUtils.stringForURI}} does not compact URI with ":" in localname
> as the compacted
> prefixed form gets rejected by {{FmtUtils.validPNameChar(ch)}} function.
> However,
> according to the SPARQL specification ";" is allowed in prefixed form, see:
> https://www.w3.org/TR/sparql11-query/#rPN_LOCAL
> *Note* it ":" was not allowed in localname in older versions of the document
> (before 2013):
> https://www.w3.org/TR/2012/WD-sparql11-query-20120105/#rPN_LOCAL
> *Proposed Fix*: add the following line to FmtUtils.validPNameChar(ch):
> {noformat}
> if ( ch == ':' ) return true ;
> {noformat}
> *Proposed Test* add to TestFmtUtils:
> {noformat}
> @Test
> public void stringForURI_colonInLocalname_shouldCompact() {
> String uri = aUri + "local:name";
> final String result = FmtUtils.stringForURI(uri, getPrefixMapping());
> assertEquals("zz:local:name", result);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
