[
https://issues.apache.org/jira/browse/JENA-1405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218429#comment-16218429
]
ASF GitHub Bot commented on JENA-1405:
--------------------------------------
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/294#discussion_r146827609
--- Diff:
jena-arq/src/main/java/org/apache/jena/riot/adapters/AdapterFileManager.java ---
@@ -285,6 +286,12 @@ protected Model readModelWorker(Model model, String
filenameOrURI, String baseUR
if ( baseURI == null )
baseURI = SysRIOT.chooseBaseIRI(filenameOrURI) ;
try(TypedInputStream in =
streamManager.openNoMapOrNull(mappedURI)) {
+ if ( in == null )
+ {
+ if ( log.isDebugEnabled() )
+ log.debug("Failed to locate '"+mappedURI+"'") ;
--- End diff --
As I understand it, `log.debug("Failed to locate '{}'", mappedURI) `
[avoids the need](https://www.slf4j.org/faq.html#logging_performance) to
explicitly check `isDebugEnabled()`.
> Possible NPE in AdaptorFileManager
> ----------------------------------
>
> Key: JENA-1405
> URL: https://issues.apache.org/jira/browse/JENA-1405
> Project: Apache Jena
> Issue Type: Bug
> Affects Versions: Jena 3.4.0
> Reporter: Rob Vesse
> Assignee: Rob Vesse
> Priority: Minor
>
> Encountered this after updating an old test harness to the latest libraries:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException
> at
> org.apache.jena.riot.adapters.AdapterFileManager.readModelWorker(AdapterFileManager.java:288)
> at
> org.apache.jena.util.FileManager.loadModelWorker(FileManager.java:305)
> at org.apache.jena.util.FileManager.loadModel(FileManager.java:258)
> at org.apache.jena.util.junit.Manifest.<init>(Manifest.java:55)
> at
> org.apache.jena.util.junit.TestFactoryManifest.oneManifest(TestFactoryManifest.java:46)
> at
> org.apache.jena.util.junit.TestFactoryManifest.oneManifest(TestFactoryManifest.java:62)
> at
> org.apache.jena.util.junit.TestFactoryManifest.process(TestFactoryManifest.java:38)
> at com.cray.km.arq.suites.CqeTestFactory.make(CqeTestFactory.java:62)
> at
> com.cray.km.arq.suites.ReducedDAWGSuite.<init>(ReducedDAWGSuite.java:62)
> at
> com.cray.km.arq.suites.ReducedDAWGSuite.suite(ReducedDAWGSuite.java:42)
> at com.cray.km.arq.TestDAWG.suite(TestDAWG.java:55)
> at com.cray.km.arq.TestDAWG.main(TestDAWG.java:46)
> {noformat}
> The NPE occurs because the Code fails to check that the input stream isn't
> {{null}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
