[ 
https://issues.apache.org/jira/browse/JENA-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272807#comment-16272807
 ] 

ASF GitHub Bot commented on JENA-1438:
--------------------------------------

Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/320#discussion_r154109219
  
    --- Diff: 
jena-text/src/main/java/org/apache/jena/query/text/TextQueryPF.java ---
    @@ -319,13 +311,13 @@ private StrMatch objectToStruct(PropFuncArg 
argObject, boolean executionTime) {
     
                 String lang = o.getLiteralLanguage();
                 RDFDatatype dt = o.getLiteralDatatype() ;
    -            if (noLang(lang)) {
    +            if (lang.isEmpty()) {
                     if (dt != null && dt != XSDDatatype.XSDstring) {
                         log.warn("Object to text query is not a string") ;
                         return null ;
                     }
                 }
    -            lang = fixLang(lang);
    +            lang = lang.isEmpty() ? null : lang;
    --- End diff --
    
    I like 
[`emptyToNull`](https://google.github.io/guava/releases/19.0/api/docs/com/google/common/base/Strings.html#emptyToNull(java.lang.String))
 for this, but this isn't a problem or anything.


> rdf:langString argument to text:query silently ignored
> ------------------------------------------------------
>
>                 Key: JENA-1438
>                 URL: https://issues.apache.org/jira/browse/JENA-1438
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Jena
>    Affects Versions: Jena 3.5.0
>         Environment: N/A
>            Reporter: Code Ferret
>            Priority: Minor
>
> Queries of the form:
>     {{?s text:query "some string"@lang-code}}
> return no results even when there are matches found by the _equivalent_:
>     {{?s text:query ("some string" "lang:lang-code")}}
> {quote}
> Note the above _equivalent_ form is currently valid only if 
>     {{text:multilingualSupport false}}.
> {quote} See [JENA-1437|https://issues.apache.org/jira/browse/JENA-1437]
> A reasonable fix is to recognize the {{rdf:langString}} case and treat it as 
> the _equivalent_ form referring to the {{text:defautlField}}; otherwise, at 
> least an error should be indicated.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to