[
https://issues.apache.org/jira/browse/JENA-1451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16299896#comment-16299896
]
ASF GitHub Bot commented on JENA-1451:
--------------------------------------
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/333#discussion_r158256408
--- Diff:
jena-arq/src/test/java/org/apache/jena/sparql/core/AbstractTestDataset.java ---
@@ -116,4 +116,24 @@
ds.addNamedModel(graphName, model1) ;
assertFalse("Dataset should not be empty after a named graph has
been added!", ds.isEmpty());
}
+
+ @Test public void dataset_07()
+ {
+ String graphName = "http://example/"; ;
+ Dataset ds = createDataset() ;
+ ds.addNamedModel(graphName, model1) ;
+ assertTrue("Named graph not found",
ds.containsNamedModel(graphName));
+ }
+
+ // Even if empty, union and named default graph exist (sort of).
+
+ @Test public void dataset_08() {
+ Dataset ds = createDataset();
+ assertTrue("Union named graph not found",
ds.containsNamedModel(Quad.unionGraph.getURI()));
+ }
+
+ @Test public void dataset_09() {
+ Dataset ds = createDataset();
+ assertTrue("Named default graph not found",
ds.containsNamedModel(Quad.defaultGraphIRI.getURI()));
--- End diff --
This message seems a little confusing to me (`Named default graph`), maybe:
```
Default graph not found under its URI ( "+Quad.defaultGraphIRI.getURI()+" )"
```
is verbose, but very clear.
> DatasetFactory.createGeneral() never contains default graph
> -----------------------------------------------------------
>
> Key: JENA-1451
> URL: https://issues.apache.org/jira/browse/JENA-1451
> Project: Apache Jena
> Issue Type: Bug
> Components: ARQ
> Affects Versions: Jena 3.6.0
> Reporter: Adam Jacobs
> Priority: Minor
>
> See:
> http://mail-archives.apache.org/mod_mbox/jena-dev/201712.mbox/<0a67c2ce-f414-3eae-51dc-226768d4facd%40apache.org>
>
> Model m1 = ModelFactory.createDefaultModel();
> m1.add(m1.createResource(), m1.createProperty("foo"),
> m1.createResource());
> Dataset memory = DatasetFactory.create();
> Dataset general = DatasetFactory.createGeneral();
> memory.getDefaultModel().add(m1);
> general.getDefaultModel().add(m1);
> //Memory model contains default graph. General model does not.
>
> System.out.println(memory.containsNamedModel(Quad.defaultGraphIRI.getURI()));
> //true
>
> System.out.println(general.containsNamedModel(Quad.defaultGraphIRI.getURI()));
> //false
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
