[ 
https://issues.apache.org/jira/browse/JENA-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388486#comment-16388486
 ] 

ASF GitHub Bot commented on JENA-1454:
--------------------------------------

Github user ajs6f commented on a diff in the pull request:

    https://github.com/apache/jena/pull/373#discussion_r172649522
  
    --- Diff: 
jena-fuseki2/jena-fuseki-core/src/main/java/org/apache/jena/fuseki/servlets/ResponseResultSet.java
 ---
    @@ -131,26 +130,30 @@ public static void doResponseResultSet(HttpAction 
action, ResultSet resultSet, P
                 contentType = contentTypeTextPlain ;
     
             // Some kind of general dispatch is neater but there are quite a 
few special cases.
    +        // text/plain is special because there is no ResultSetWriter for 
it (yet). 
    +        // Text plain is special because of the formatting by prologue.
    +        // text/plain is not a registered result set language. 
             //
             // JSON is special because of ?callback
    -        // 
    +        //
             // XML is special because of
             // (1) charset is a feature of XML, not the response 
             // (2) ?stylesheet=
             //
             // Thrift is special because
             // (1) charset is meaningless
             // (2) there is no boolean result form.
    -        //
    -        // Text plain is special because of the formatting by prologue.
    -        
    +
    +        if ( Objects.equals(serializationType, contentTypeTextPlain) ) {
    --- End diff --
    
    Just out of curiosity-- why `Objects.equals` here instead of 
`contentTypeTextPlain.equals` or `serializationType.equals`?


> Configurable ResultSet reading and writing
> ------------------------------------------
>
>                 Key: JENA-1454
>                 URL: https://issues.apache.org/jira/browse/JENA-1454
>             Project: Apache Jena
>          Issue Type: Improvement
>            Reporter: Andy Seaborne
>            Assignee: Andy Seaborne
>            Priority: Minor
>             Fix For: Jena 3.7.0
>
>
> Same patterns as {{RDFParser}}, {{RDFWriter}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to