[
https://issues.apache.org/jira/browse/JENA-1524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16438743#comment-16438743
]
ASF GitHub Bot commented on JENA-1524:
--------------------------------------
GitHub user christopher-johnson opened a pull request:
https://github.com/apache/jena/pull/399
[JENA-1524] renames jena-arq org.apache.jena.system to org.apache.jena.sys
The changes are superficial, but will break existing implementations. The
thinking pattern here is shallow, and there may be better ways to restructure
the `org.apache.jena.system` package (like merging the split in a new project).
Since this PR is JPMS related, I also added the Automatic-Module-Name to
`<manifestEntries>` for most of the projects. This ModuleFinder mechanism is
documented
[here](https://docs.oracle.com/javase/10/docs/api/java/lang/module/ModuleFinder.html#of(java.nio.file.Path...)).
These names are consistent with semantics described in [this
specification](https://docs.oracle.com/javase/specs/jls/se10/html/jls-6.html#jls-6.5)
and follow the conventions of other Apache projects like
`org.apache.commons.io`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/christopher-johnson/jena split-system
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/399.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #399
----
commit ee9fd831f588d02b500a78811b9a78c418cfc89e
Author: Christopher Hanna Johnson <chjohnson39@...>
Date: 2018-04-15T13:35:51Z
[JENA-1524] renames jena-arq org.apache.jena.system to org.apache.jena.sys
adds Automatic-Module-Name to manifestEntries
----
> org.apache.jena.system is split by org.apache.jena.arq and
> org.apache.jena.core
> -------------------------------------------------------------------------------
>
> Key: JENA-1524
> URL: https://issues.apache.org/jira/browse/JENA-1524
> Project: Apache Jena
> Issue Type: Bug
> Components: Jena
> Affects Versions: Jena 3.7.0
> Reporter: Christopher Johnson
> Priority: Major
>
> a JPMS module cannot require both org.apache.jena.arq and
> org.apache.jena.core since org.apache.jena.system can be read from both.
> This cannot be resolved with --patch-module since arq and core provide
> different implementations. Suggestion is to make a distinction by renaming
> system to sys in either one.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
