[ 
https://issues.apache.org/jira/browse/JENA-1525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439781#comment-16439781
 ] 

ASF GitHub Bot commented on JENA-1525:
--------------------------------------

Github user christopher-johnson commented on a diff in the pull request:

    https://github.com/apache/jena/pull/400#discussion_r181829734
  
    --- Diff: jena-db/pom.xml ---
    @@ -75,6 +79,13 @@
           <plugin>
             <groupId>org.apache.maven.plugins</groupId>
             <artifactId>maven-jar-plugin</artifactId>
    +        <configuration>
    +          <archive>
    +            <manifestEntries>
    +              
<Automatic-Module-Name>${automatic.module.name}</Automatic-Module-Name>
    --- End diff --
    
    yes.  the Automatic-Module-Name is like a qualified jar name.  All of the 
packages in the jena-db project will be visible with Automatic-Module-Name: 
org.apache.jena.db.  You would not want to split the components of 
`org.apache.jena.dboe` into separate modules, so it makes sense to unify them.  
It generally seems to be coherent to align the module name with a top level 
package name when there is one package tree per project.  It might be advisable 
to make a separate jar configuration for `org.apache.jena.tbd2` that has a 
matching module name (if granularity is a requirement).


> Add <Automatic-Module-Name> to <manifestEntries> for each jar module.
> ---------------------------------------------------------------------
>
>                 Key: JENA-1525
>                 URL: https://issues.apache.org/jira/browse/JENA-1525
>             Project: Apache Jena
>          Issue Type: Improvement
>            Reporter: Andy Seaborne
>            Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to