[
https://issues.apache.org/jira/browse/JENA-1532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448732#comment-16448732
]
ASF GitHub Bot commented on JENA-1532:
--------------------------------------
Github user anujgandharv commented on a diff in the pull request:
https://github.com/apache/jena/pull/406#discussion_r183507712
--- Diff:
jena-text-es/src/main/java/org/apache/jena/query/text/es/TextIndexES.java ---
@@ -422,6 +422,27 @@ public EntityDefinition getDocDef() {
}
private String parse(String fieldName, String qs, String lang) {
+ //Escape special characters if any in the query string
+ qs = qs.replaceAll("\\:", "\\\\:")
--- End diff --
So this is indeed a bit of a style question. But keeping that aside, under
the hood, ```str.replaceAll()``` is equivalent to
```Pattern.compile(regex).matcher(str).replaceAll(repl)```
I can rewrite the ```str.replaceAll``` like above, but I genuinely do not
see any major gains. You get to make the final call. :) Changing it is quite
trivial from my side. Its more the logistics that I would like to avoid, if
possible.
> Jena Text Elastic Search Does not perform proper date comparison during query
> -----------------------------------------------------------------------------
>
> Key: JENA-1532
> URL: https://issues.apache.org/jira/browse/JENA-1532
> Project: Apache Jena
> Issue Type: Bug
> Components: Text
> Affects Versions: Jena 3.7.0
> Reporter: Anuj Kumar
> Priority: Major
>
> Jena Text Elastic Search is an implementation of the text query capability of
> Jena to perform text based searching and Filtering of data. It uses [Query
> String
> Query|https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html]
> capability of elastic search to perform searches.
> We found a bug in the implementation where searching on date values does not
> work properly. For example, if we have a following text query:
> {code:java}
> SELECT ?s { ?s text:query ('2016-12-01T15:31:10-05:00') ;{code}
> then the implementation threw exception because there are unescaped ":"
> (colon) in the value. Since ":" is a reserved character in the Query String
> Query capability of Elastic search, we have to escape the character.
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
