[
https://issues.apache.org/jira/browse/JENA-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16507498#comment-16507498
]
ASF GitHub Bot commented on JENA-1562:
--------------------------------------
Github user ajs6f commented on a diff in the pull request:
https://github.com/apache/jena/pull/434#discussion_r194269455
--- Diff: jena-arq/src/main/java/org/apache/jena/sparql/core/GraphView.java
---
@@ -165,6 +165,9 @@ public void performDelete( Triple t ) {
Node o = t.getObject() ;
dsg.delete(g, s, p, o) ;
}
+
+ // Subclasses may wish to provide graphBaseSize otherwise GraphBase
uses find()
--- End diff --
Maybe this is just where I like to find things, but I'd rather `@Override
protected int graphBaseSize() { return super.graphBaseSize(); }` with this as a
Javadoc comment.
> TDB2 Graph.size() is much slower than TDB1.
> -------------------------------------------
>
> Key: JENA-1562
> URL: https://issues.apache.org/jira/browse/JENA-1562
> Project: Apache Jena
> Issue Type: Bug
> Affects Versions: Jena 3.7.0
> Reporter: Andy Seaborne
> Assignee: Andy Seaborne
> Priority: Major
> Fix For: Jena 3.8.0
>
>
> TDB2 {{Graph.size()}} is much slower than TDB1.
> TDB2 {{Graph.size()}} relies on {{GraphBase.size}}, which uses
> {{graph.find(ANY,ANY,ANY)}} which creates nodes and triples unnecessarily for
> the count.
> TDB1 has code to use the primary tupleindex size() operation and it 50x
> faster on 5m triples in the default graph.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
