Github user kinow commented on the issue:

    https://github.com/apache/jena/pull/436
  
    The docs look really good! Only feedback I have:
    
    * It's possible to avoid the empty commit, by amending the last commit 
adding "this closes #123". That's what I normally do when I work in other 
projects.
    * Should we also merge + --no-ff, or is fetch/rebase all right too? I've 
done it a few times, but happy to do merge + --no-ff instead if desirable 
    * Perhaps a link in the website for it, under Contributing? Or a new page? 
It's probably related to 
http://jena.apache.org/getting_involved/reviewing_contributions.html too? (or 
maybe there's already a link somewhere?)
    
    Thanks


---

Reply via email to