[
https://issues.apache.org/jira/browse/JENA-1590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577174#comment-16577174
]
ASF GitHub Bot commented on JENA-1590:
--------------------------------------
GitHub user kinow opened a pull request:
https://github.com/apache/jena/pull/460
JENA-1590: fix if statement in RDFWriter#output
Eclipse alerted for some Dead code in this class, and after having a look,
I thought we actually had to check the `lang` in the second `if`, not `ct`?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kinow/jena JENA-1590
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jena/pull/460.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #460
----
commit 88edbdbeb305e8f4a9a37f2f2299d1699dde149f
Author: Bruno P. Kinoshita <kinow@...>
Date: 2018-08-11T12:49:59Z
JENA-1590: fix if statement in RDFWriter#output
----
> Fix if statement in RDFWriter#output(String)
> --------------------------------------------
>
> Key: JENA-1590
> URL: https://issues.apache.org/jira/browse/JENA-1590
> Project: Apache Jena
> Issue Type: Improvement
> Components: ARQ
> Affects Versions: Jena 3.8.0
> Reporter: Bruno P. Kinoshita
> Assignee: Bruno P. Kinoshita
> Priority: Minor
> Fix For: Jena 3.9.0
>
>
> RDFWriter#output(String) appears to have a bug in the two if statements.
> Sending a pull request to fix it (though in theory the second if won't
> happen... it's still better to keep the defensive programming IMO)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)