Github user rvesse commented on a diff in the pull request:

    https://github.com/apache/jena/pull/463#discussion_r211191248
  
    --- Diff: 
jena-arq/src/main/java/org/apache/jena/sparql/core/DynamicDatasets.java ---
    @@ -56,8 +55,8 @@ public static DatasetGraph 
dynamicDataset(DatasetDescription description, Datase
                if (description.isEmpty() )
                        return dsg;
                
    -        Set<Node> defaultGraphs = 
NodeUtils.convertToNodes(description.getDefaultGraphURIs()) ; 
    -        Set<Node> namedGraphs = 
NodeUtils.convertToNodes(description.getNamedGraphURIs()) ;
    +        Collection<Node> defaultGraphs = 
NodeUtils.convertToNodes(description.getDefaultGraphURIs()) ; 
    --- End diff --
    
    Isn't the point of using sets here to remove duplicates or is that now done 
in the `NodeUtils.convertToNodes()` method?


---

Reply via email to