[ 
https://issues.apache.org/jira/browse/JENA-1642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700825#comment-16700825
 ] 

ASF GitHub Bot commented on JENA-1642:
--------------------------------------

GitHub user jsarjeant opened a pull request:

    https://github.com/apache/jena/pull/500

    JENA-1642: Check has value for header instead of is true

    When using schemagen from the maven plugin the `header` option does not 
work. `header` is intended to be a template string and when `isTrue` is checked 
the string is cast to a boolean and the `BadBooleanException` is thrown. I 
believe we should check for existence here instead of "truthiness"
    
    
    Also, it appears that the maven tools are no being built as part of the 
main project. Is that the case?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jsarjeant/jena master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/jena/pull/500.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #500
    
----
commit 471d1f8511def353f1b64776c2a986d1e6d8ab45
Author: Joseph Sarjeant <joseph_sarjeant@...>
Date:   2018-11-27T18:08:43Z

    Check has value for header instead of is true

----


> Schemagen configuration option "header" throws exception
> --------------------------------------------------------
>
>                 Key: JENA-1642
>                 URL: https://issues.apache.org/jira/browse/JENA-1642
>             Project: Apache Jena
>          Issue Type: Bug
>          Components: Jena, Maven Tools
>    Affects Versions: Jena 3.6.0
>            Reporter: Joseph Sarjeant
>            Priority: Minor
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> When using Jena Schemagen from the maven plugin the configuration option for 
> `header` throws a `BadBooleanException`. Schemagen is checking for `isTrue` 
> for this option while the value specified is intended to be a String. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to