grahamtriggs commented on issue #527: SDB Transform - improve performance of OPTIONAL, MINUS URL: https://github.com/apache/jena/pull/527#issuecomment-462799056 @afs OK, I've changed the comments For tests, what would you like to see? Currently, as it is enabled by default, the transformation is being applied to all of the existing tests that query a store, and shows that nothing untoward is being applied to any of those queries. I intended to create some unit tests for the transformation, that much like the example provided above would have before / after versions of the query, and compare that the transformed algebra is correct. But the current interfaces of Op don't easily allow a comparison between two different sets of algebra (as far as I can see). I could do a text match on the Op.toString(), but that might be liable to test failures from a small change that doesn't impact the execution. Alternatively, tests that execute transformed queries against a test database may not catch that a change has meant that the transformation doesn't actually make any changes to the query (and so the resulting query is still functional, it would just lose performance on larger datasets. Any thoughts?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
