xristy commented on issue #536: Add support SurroundQueryParser to jena-text URL: https://github.com/apache/jena/pull/536#issuecomment-475756380 Thanks for patience w/ my lack of response - slammed is all I can say. In any event, I agree with Osma’s comments. After the merge, then we can see what sort of interactions with other features, in particular, multi-language, occur. I’m not confident that they will play well together which would have to be clarified in the documentation. If there are other query parsers that are desirable to add in the future it might be worth extending the assembler a bit to handle such extensions. Regards, Chris > On Mar 22, 2019, at 11:26 AM, Osma Suominen <notificati...@github.com> wrote: > > @afs <https://github.com/afs> Thanks for the reminder > > @DamienFontaine <https://github.com/DamienFontaine> Any chance to refactor parseQuery just a little bit? There is quite a lot of redundancy and repetition now. > > For example > > combine QueryParser and AnalyzingQueryParser cases into one, since their code is (nowadays) identical > handle the SurroundQueryParser case separate from the others since it's treated differently - for the others, avoid repeating the same boilerplate (e.g. qp.setAllowLeadingWildcard(true)) over and over > Another option would be to create a class that wraps SurroundQueryParser giving it a QueryParser interface, so that it can be handled just like the others (ie revert the merging of two methods). But that may be difficult in practice - I assume there's a reason why SurroundQueryParser isn't a QueryParser in Lucene already although I haven't looked at it in detail. > > If we can get the line count in TextIndexLucene down by a dozen or so, I'm happy. And of course we need some kind of promise to update the jena-text documentation accordingly after this gets merged. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub <https://github.com/apache/jena/pull/536#issuecomment-475686611>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ADYNFlCnqgmgjtGlhWCNchd6tkQR-6Seks5vZQQrgaJpZM4bHfHA>. >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
