afs commented on a change in pull request #568: Add Aggregate Median to SPARQL
ARQ syntax
URL: https://github.com/apache/jena/pull/568#discussion_r288160427
##########
File path:
jena-arq/src/main/java/org/apache/jena/sparql/expr/aggregate/AggMedian.java
##########
@@ -78,7 +82,7 @@ public boolean equals(Aggregator other, boolean bySyntax) {
@Override
protected void accumulate(NodeValue nv, Binding binding, FunctionEnv
functionEnv)
{
- if ( DEBUG ) System.out.println("median: "+nv) ;
+ log.debug("median "+ nv);
Review comment:
Style point: add `if ( log.isEnabled() )` otherwise `"median "+ nv` is
calculated regardless of loggingbe on or off.
Or use `("median {}", nv)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
