kinow commented on a change in pull request #586: JENA-1733: SHACL engine, command line validator and Fuseki service. URL: https://github.com/apache/jena/pull/586#discussion_r306674122
########## File path: jena-shacl/src/main/java/org/apache/jena/shacl/engine/constraint/ClosedConstraint.java ########## @@ -0,0 +1,143 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.jena.shacl.engine.constraint; + +import static org.apache.jena.shacl.lib.ShLib.displayStr; + +import java.util.Collections; +import java.util.HashSet; +import java.util.List; +import java.util.Set; + +import org.apache.jena.graph.Graph; +import org.apache.jena.graph.Node; +import org.apache.jena.graph.Triple; +import org.apache.jena.shacl.engine.ValidationContext; +import org.apache.jena.shacl.lib.G; +import org.apache.jena.shacl.lib.GN; +import org.apache.jena.shacl.parser.Constraint; +import org.apache.jena.shacl.parser.ShaclParseException; +import org.apache.jena.shacl.parser.Shape; +import org.apache.jena.shacl.vocabulary.SHACL; +import org.apache.jena.sparql.path.Path; +import org.apache.jena.sparql.path.PathFactory; +import org.apache.jena.sparql.util.graph.GraphList; + +/** sh:closed */ +public class ClosedConstraint implements Constraint { + + private final Set<Node> expected; + private final Set<Node> ignoredProperties; + private final boolean active; + + public ClosedConstraint(Graph shapeGraph, Node shapeNode, boolean active) { + expected = shapeProperties(shapeGraph, shapeNode); + this.active = active; + // Set vs List + List<Node> ignored = ignoredProperties(shapeGraph, shapeNode); + ignoredProperties = (ignored == null) ? Collections.emptySet() : new HashSet<>(ignored); + } + + private static List<Node> ignoredProperties(Graph shapesGraph, Node shNode) { + List<Node> ignoredProperties = null; + if ( G.contains(shapesGraph, shNode, SHACL.ignoredProperties, null) ) { + Node ignored = G.getOneSP(shapesGraph, shNode, SHACL.ignoredProperties); + if ( ignored != null ) { + ignoredProperties = GraphList.members(GN.create(shapesGraph, ignored)) ; + ignoredProperties.forEach(p->{ + if ( ! p.isURI() ) + throw new ShaclParseException("Only URIs allowed in sh:ignoredProperties at "+displayStr(shNode)); + }); + } + } + return ignoredProperties; + } + + @Override + public void validateNodeShape(ValidationContext vCxt, Graph data, Shape shape, Node focusNode) { + validate(vCxt, data, shape, focusNode); + } + + @Override + public void validatePropertyShape(ValidationContext vCxt, Graph data, Shape shape, Node focusNode, Path path, Set<Node> valueNodes) { + // Shame valueNodes is calculated. Or is it? + // Only [ sh:path ex:property ], not other constraints. + // XXX Small optimization: no property shape constraints => no valuenodes. + validate(vCxt, data, shape, focusNode); + } + + private void validate(ValidationContext vCxt, Graph data, Shape shape, Node focusNode) { + if ( ! active ) + return; + + // My reading of: + // 4.8.1 sh:closed, sh:ignoredProperties + // + // "a predicate that is not explicitly enumerated as a _value_ of sh:path" + // + // means the predicate is the object of the sh:path triple, + // and path other than a single predicate has a value that + // is a bnode (usually). + + Set<Node> actual = properties(data, focusNode); + boolean conforms = true; Review comment: Not used? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
