[ 
https://issues.apache.org/jira/browse/JENA-1864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17070449#comment-17070449
 ] 

Andy Seaborne commented on JENA-1864:
-------------------------------------

Hi [~virresh]

The PR looks fine as-is.

The issue of whether to print "base" or not can be separated out - it affects 
the pretty write as well. There is also a question of style : "BASE" or "@base" 
("PREFIX"/"@prefix" is already switchable).

{{WriterStreamRDFBase}} can acquire a {{Context}} - I've done that my copy 
(small change, but quite a files altered! The wonders of Eclipse signature 
change!) and I can PR that after PR #179 is merged if that works for you.

So get this PR into the code base as-is because it fixes the presenting problem 
of no base, andhence unstable RDF output, and do the deeper cleaning of 
`WriterStreamRDFBase` and generally refactoring code.


> Inconsistent Turtle serializers
> -------------------------------
>
>                 Key: JENA-1864
>                 URL: https://issues.apache.org/jira/browse/JENA-1864
>             Project: Apache Jena
>          Issue Type: Bug
>    Affects Versions: Jena 3.14.0
>         Environment: My Configuration:
> OS: Ubuntu 18.04
> java version "1.8.0_111"
> javac 1.8.0_242
> Jena Version: 3.14.0
>            Reporter: Viresh Gupta
>            Priority: Major
>
> The turtle serializers provided for default model in Jena don't work as 
> expected. Moreover, the docs lack on which methods to use in which case.
> I found the following methods that seem to work:
>  # model.write()  (A.ttl)
>  # RDFWriter   (B.ttl)
>  # RDFDataMgr  (C.ttl)
> I'm providing a minimum working example along with the outputs using a sample 
> turtle file from Turtle specifications (ggoblin.ttl – Example 1 from 
> [https://www.w3.org/TR/turtle/|https://www.w3.org/TR/turtle/#sec-examples]) 
> in a gist: [https://gist.github.com/virresh/5a28dc3adb1f40bf9070e2cb4ecfa90d]
>  
> The issue:
>  # "@base" directive is not printed when writing with the TURTLE_BLOCK and 
> TURTLE_FLAT format in RDFWriter
>  #  There is no way to provide "@base" inside the RDFDataMgr. Expected output 
> was something like <#spiderman>
>  # RDFDataMgr doesn't respect the prefix supplied, e.g I manually added 
> prefix "@base", however, the output (C.ttl) still converts the relative 
> entities into their absolute form, whereas I expected it to do something like 
> base:#spiderman at the very least
>  
> I'll be happy to help with the issue if it doesn't fall into the "wont-fix" 
> category.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to