Actually, I was asking if we has a standard or recommendation one way or
the other.    I'll take a look again tomorrow, I didn't have much time to
review.  If you need to proceed without my approval, feel free.

Claude

On Wed, Feb 17, 2021 at 10:52 PM Andy Seaborne <a...@apache.org> wrote:

>
>
> On 17/02/2021 17:37, Claude Warren wrote:
> > I noticed that the changes to querybuilder converted a bunch of
> java.util.x
> > import to java.util.*
>
> This is what PR review is for. It does help to be in-context.
>
> I have updated the PR - can you approve it now please?
>
> I was in the code because I had to make lot of changes to redo the
> direct calls to Binding implementation classes.
>
>      Andy
>
> > I have always heard that the asterisk should not be used in the import
> > statement as it can cause conflicts that are very hard to debug when new
> > versions of the specific library are updated and conflicting classes
> added.
> >
> > Is there a reason to use the '*' import?
> >
> > Claude
> >
>


-- 
I like: Like Like - The likeliest place on the web
<http://like-like.xenei.com>
LinkedIn: http://www.linkedin.com/in/claudewarren

Reply via email to