[ 
https://issues.apache.org/jira/browse/JENA-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17501961#comment-17501961
 ] 

Florian Kleedorfer commented on JENA-2301:
------------------------------------------

> Are we talking about target shapes or node/property shapes that are no 
> targets but are part of a target shape?

Target shapes. The whole point is that these shapes are used to select nodes 
from the data graph. In the extreme case there is nothing but the 
sh:target(Class|ObjectOf|...) triple.

the 'variation of (1)' is also overly specific, though less so than (1). May 
have its merits, but its not my favourite. It does not cover any of the cases 
you mention (sh:closed, sh:severity, sh:message). 

in (4), is the suggestion that the transform visits the shapes, any 
modifications are applied to a view of the shapes graph, and afterwards, the 
modified shapes graph view is parsed again? The advantage would be that the 
modified graph view could be serialized and used outside of jena - right?


> Allow to activate/deactivate shapes
> -----------------------------------
>
>                 Key: JENA-2301
>                 URL: https://issues.apache.org/jira/browse/JENA-2301
>             Project: Apache Jena
>          Issue Type: Improvement
>          Components: SHACL
>            Reporter: Florian Kleedorfer
>            Priority: Trivial
>
> I have a use case in which I need to toggle a shape's 'deactivated` flag 
> programatically.
> The current workaround I'm using is to extract the shape's subgraph, set the 
> flag in the extracted graph, and then parse it again. If there is a simpler 
> workaround, I'll be happy to use that. 
> Otherwise, here are my suggestions (for Shape.java):
> * Make the `deactivated` flag non-final and add a setter.
> * Provide a way to clone a shape and change the flag underway.
> Cheers!



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to