afs commented on code in PR #201:
URL: https://github.com/apache/jena-site/pull/201#discussion_r1840196617


##########
source/documentation/fuseki2/fuseki-configuration.md:
##########
@@ -56,7 +56,7 @@ Some useful prefix declarations:
     PREFIX fuseki:  <http://jena.apache.org/fuseki#>
     PREFIX rdf:     <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
     PREFIX rdfs:    <http://www.w3.org/2000/01/rdf-schema#>
-    PREFIX tdb1:    <http://jena.hpl.hp.com/2008/tdb#>
+    PREFIX tdb:     <http://jena.hpl.hp.com/2008/tdb#>

Review Comment:
   I think it's better to keep `tdb1` and `tdb2` and use them consistently.
   



##########
source/documentation/fuseki2/fuseki-configuration.md:
##########
@@ -56,7 +56,7 @@ Some useful prefix declarations:
     PREFIX fuseki:  <http://jena.apache.org/fuseki#>
     PREFIX rdf:     <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
     PREFIX rdfs:    <http://www.w3.org/2000/01/rdf-schema#>
-    PREFIX tdb1:    <http://jena.hpl.hp.com/2008/tdb#>
+    PREFIX tdb:     <http://jena.hpl.hp.com/2008/tdb#>

Review Comment:
   The in-memory example needs updating as well.
   
   Renaming section "TDB" as "TDB1" and swapping with "TDB2" would be good.
   Using TDB2 is preferred. TDB1 is mostly legacy.
   



##########
source/documentation/fuseki2/fuseki-configuration.md:
##########
@@ -56,7 +56,7 @@ Some useful prefix declarations:
     PREFIX fuseki:  <http://jena.apache.org/fuseki#>
     PREFIX rdf:     <http://www.w3.org/1999/02/22-rdf-syntax-ns#>
     PREFIX rdfs:    <http://www.w3.org/2000/01/rdf-schema#>
-    PREFIX tdb1:    <http://jena.hpl.hp.com/2008/tdb#>
+    PREFIX tdb:     <http://jena.hpl.hp.com/2008/tdb#>

Review Comment:
   That's a lot of changes I'm suggesting!
   
   Here's every in one alternative PR:
   https://github.com/apache/jena-site/pull/202
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jena.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to