On 3 December 2011 23:05, <[email protected]> wrote: > Author: pmouawad > Date: Sat Dec 3 23:05:54 2011 > New Revision: 1210028 > > URL: http://svn.apache.org/viewvc?rev=1210028&view=rev > Log: > Bug 50086 - Password fields not Hidden in JMS Publisher, JMS Subscriber, Mail > Reader sampler, SMTP sampler and Database Configuration
However, the passwords are still stored unencrypted in the JMX files, so I think it is potentially misleading to hide them on screen. It will probably be difficult to implement a secure platform-independent encryption mechanism that is easy to use and still allows JMXs to be shared if necessary. So meanwhile I think the restriction needs to be clearly documented in component reference. > Modified: > > jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java > > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java > > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSubscriberGui.java > > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/gui/MailReaderSamplerGui.java > > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java > jmeter/trunk/xdocs/changes.xml > > Modified: > jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java > URL: > http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java?rev=1210028&r1=1210027&r2=1210028&view=diff > ============================================================================== > --- > jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java > (original) > +++ > jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementBeanInfo.java > Sat Dec 3 23:05:54 2011 > @@ -29,6 +29,7 @@ import java.util.Set; > > import org.apache.commons.lang.StringUtils; > import org.apache.jmeter.testbeans.BeanInfoSupport; > +import org.apache.jmeter.testbeans.gui.TypeEditor; > import org.apache.jorphan.logging.LoggingManager; > import org.apache.log.Logger; > > @@ -97,7 +98,7 @@ public class DataSourceElementBeanInfo e > p = property("username"); > p.setValue(NOT_UNDEFINED, Boolean.TRUE); > p.setValue(DEFAULT, ""); > - p = property("password"); > + p = property("password", TypeEditor.PasswordEditor); > p.setValue(NOT_UNDEFINED, Boolean.TRUE); > p.setValue(DEFAULT, ""); > } > > Modified: > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java > URL: > http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java?rev=1210028&r1=1210027&r2=1210028&view=diff > ============================================================================== > --- > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java > (original) > +++ > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSPublisherGui.java > Sat Dec 3 23:05:54 2011 > @@ -35,6 +35,7 @@ import org.apache.jmeter.protocol.jms.sa > import org.apache.jmeter.samplers.gui.AbstractSamplerGui; > import org.apache.jmeter.testelement.TestElement; > import org.apache.jmeter.util.JMeterUtils; > +import org.apache.jorphan.gui.JLabeledPasswordField; > import org.apache.jorphan.gui.JLabeledTextArea; > import org.apache.jorphan.gui.JLabeledTextField; > > @@ -86,7 +87,7 @@ public class JMSPublisherGui extends Abs > > private final JLabeledTextField jmsUser = new > JLabeledTextField(JMeterUtils.getResString("jms_user")); //$NON-NLS-1$ > > - private final JLabeledTextField jmsPwd = new > JLabeledTextField(JMeterUtils.getResString("jms_pwd")); //$NON-NLS-1$ > + private final JLabeledTextField jmsPwd = new > JLabeledPasswordField(JMeterUtils.getResString("jms_pwd")); //$NON-NLS-1$ > > private final JLabeledTextField iterations = new > JLabeledTextField(JMeterUtils.getResString("jms_itertions")); //$NON-NLS-1$ > > > Modified: > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSubscriberGui.java > URL: > http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSubscriberGui.java?rev=1210028&r1=1210027&r2=1210028&view=diff > ============================================================================== > --- > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSubscriberGui.java > (original) > +++ > jmeter/trunk/src/protocol/jms/org/apache/jmeter/protocol/jms/control/gui/JMSSubscriberGui.java > Sat Dec 3 23:05:54 2011 > @@ -34,6 +34,7 @@ import org.apache.jmeter.protocol.jms.sa > import org.apache.jmeter.samplers.gui.AbstractSamplerGui; > import org.apache.jmeter.testelement.TestElement; > import org.apache.jmeter.util.JMeterUtils; > +import org.apache.jorphan.gui.JLabeledPasswordField; > import org.apache.jorphan.gui.JLabeledTextField; > > /** > @@ -72,7 +73,7 @@ public class JMSSubscriberGui extends Ab > new JLabeledTextField(JMeterUtils.getResString("jms_user")); // > $NON-NLS-1$ > > private final JLabeledTextField jmsPwd = > - new JLabeledTextField(JMeterUtils.getResString("jms_pwd")); // > $NON-NLS-1$ > + new JLabeledPasswordField(JMeterUtils.getResString("jms_pwd")); // > $NON-NLS-1$ > > private final JLabeledTextField iterations = > new JLabeledTextField(JMeterUtils.getResString("jms_itertions")); // > $NON-NLS-1$ > > Modified: > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/gui/MailReaderSamplerGui.java > URL: > http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/gui/MailReaderSamplerGui.java?rev=1210028&r1=1210027&r2=1210028&view=diff > ============================================================================== > --- > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/gui/MailReaderSamplerGui.java > (original) > +++ > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/mail/sampler/gui/MailReaderSamplerGui.java > Sat Dec 3 23:05:54 2011 > @@ -31,6 +31,7 @@ import javax.swing.JCheckBox; > import javax.swing.JComponent; > import javax.swing.JLabel; > import javax.swing.JPanel; > +import javax.swing.JPasswordField; > import javax.swing.JRadioButton; > import javax.swing.JTextField; > import javax.swing.event.ChangeEvent; > @@ -192,7 +193,7 @@ public class MailReaderSamplerGui extend > usernameBox = new JTextField(20); > addField(settingsPanel, AccountLabel, usernameBox, gbc); > > - passwordBox = new JTextField(20); > + passwordBox = new JPasswordField(20); > addField(settingsPanel, PasswordLabel, passwordBox, gbc); > > folderLabel = new JLabel(FolderLabel); > > Modified: > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java > URL: > http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java?rev=1210028&r1=1210027&r2=1210028&view=diff > ============================================================================== > --- > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java > (original) > +++ > jmeter/trunk/src/protocol/mail/org/apache/jmeter/protocol/smtp/sampler/gui/SmtpPanel.java > Sat Dec 3 23:05:54 2011 > @@ -33,6 +33,7 @@ import javax.swing.JCheckBox; > import javax.swing.JFileChooser; > import javax.swing.JLabel; > import javax.swing.JPanel; > +import javax.swing.JPasswordField; > import javax.swing.JTextArea; > import javax.swing.JTextField; > import javax.swing.event.ChangeEvent; > @@ -513,7 +514,7 @@ public class SmtpPanel extends JPanel { > tfMailToCC = new JTextField(25); > tfMailToBCC = new JTextField(25); > tfAuthUsername = new JTextField(20); > - tfAuthPassword = new JTextField(20); > + tfAuthPassword = new JPasswordField(20); > tfSubject = new JTextField(20); > tfAttachment = new JTextField(30); > tfEmlMessage = new JTextField(30); > > Modified: jmeter/trunk/xdocs/changes.xml > URL: > http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1210028&r1=1210027&r2=1210028&view=diff > ============================================================================== > --- jmeter/trunk/xdocs/changes.xml (original) > +++ jmeter/trunk/xdocs/changes.xml Sat Dec 3 23:05:54 2011 > @@ -58,6 +58,12 @@ For example a Test Action sampler with 0 > or a Debug Sampler with all fields set to False (to reduce the sample size). > </p> > > +<p> > +The menu item Options / Choose Language does not change all the displayed > text to the new language. > +[The behaviour has improved, but language change is still not fully working, > see BUG 52280] > +To override the default local language fully, set the JMeter property > "language" before starting JMeter. > +</p> > + > <!-- =================== Incompatible changes =================== --> > > <h2>Incompatible changes</h2> > @@ -228,6 +234,7 @@ Loads any additional properties found in > <li>Bug 52241 - GenericTestBeanCustomizer assumes that the default value is > the empty string</li> > <li>Bug 52242 - FileEditor does not allow output to be saved in a File </li> > <li>Bug 51093 - when loading a selection previously stored by "Save > Selection As", show the file name in the blue window bar</li> > +<li>Bug 50086 - Password fields not Hidden in JMS Publisher, JMS Subscriber, > Mail Reader sampler, SMTP sampler and Database Configuration</li> > </ul> > > <h2>Non-functional changes</h2> > >
