On 4 December 2011 16:36, Philippe Mouawad <[email protected]> wrote: > I agree with you it's not great, but don't you think we should keep it > until we find a better solution ?
We can keep for the short term, but I think the issue needs to be resolved before the next release. That is, we need to find a way to do this without file duplication. Only if that is not possible do we consider whether to keep the duplicates, in which case we need to find a way to keep them in step automatically. > As a user, it feels really strange to have French labels for Popup Menu > when I switch to English, no ? > > > I will try to find a better solution OK, but please discuss your proposal on the dev list before applying. Have a look at JM > Regards > Philippe > > On Sun, Dec 4, 2011 at 4:10 PM, sebb <[email protected]> wrote: > >> On 3 December 2011 17:31, <[email protected]> wrote: >> > Author: pmouawad >> > Date: Sat Dec 3 17:31:11 2011 >> > New Revision: 1209959 >> > >> > URL: http://svn.apache.org/viewvc?rev=1209959&view=rev >> > Log: >> > Bug 52280 - The menu item Options / Choose Language does not change all >> the displayed text to the new language >> > >> > Issue is due to the fact that on a french computer, default locale is >> fr_FR , so as _en bundles are missing it stays in French. Would be the same >> for all non english computers. >> > >> > Added: >> > >> jmeter/trunk/src/components/org/apache/jmeter/assertions/BSFAssertionResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/assertions/CompareAssertionResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/assertions/JSR223AssertionResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/config/CSVDataSetResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/config/KeystoreConfigResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/config/RandomVariableConfigResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/extractor/BSFPostProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/extractor/BeanShellPostProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/extractor/DebugPostProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/extractor/JSR223PostProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/modifiers/BSFPreProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/modifiers/BeanShellPreProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/modifiers/JSR223PreProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/sampler/DebugSamplerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/timers/BSFTimerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/timers/BeanShellTimerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/timers/ConstantThroughputTimerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/timers/JSR223TimerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/timers/SyncTimerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/BSFListenerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/BeanShellListenerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/components/org/apache/jmeter/visualizers/JSR223ListenerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/examples/org/apache/jmeter/examples/testbeans/example2/Example2Resources_en.properties >> (with props) >> > >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/sampler/AccessLogSamplerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/protocol/java/org/apache/jmeter/protocol/java/sampler/JSR223SamplerResources_en.properties >> (with props) >> > >> jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/config/DataSourceElementResources_en.properties >> (with props) >> > >> jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/processor/JDBCPostProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/processor/JDBCPreProcessorResources_en.properties >> (with props) >> > >> jmeter/trunk/src/protocol/jdbc/org/apache/jmeter/protocol/jdbc/sampler/JDBCSamplerResources_en.properties >> (with props) >> >> -1 >> >> I'm not happy with this fix. There are now two copies of the English >> properties files which have to be kept in step. >> There has to be a better way to do this. We know that the default >> property files are in English, so it ought to be possible to chose >> that instead of _en when switching. >> > > > > -- > Cordialement. > Philippe Mouawad.
