On 5 February 2012 16:35, Philippe Mouawad <[email protected]> wrote: > Hello, > I have a question regarding current implementation of Proxy. > Is it supposed to record binary protocoles ?
It was designed for recording standard HTTP sessions; these are not binary. > Cause looking at : > > - https://issues.apache.org/bugzilla/show_bug.cgi?id=49039 > > Reported issue talks about "application/soap+msbin1" which AFAIK is a > binary XML protocol. > > Besides, I think there is indeed an issue in line 381: > postData = new String(rawPostData); > should be : > postData = new String(rawPostData, PostWriter.ENCODING); Probably; there should not be any reliance on the default encoding - unless documented as such. > Cause in PostWriter, when contentEncoding is null, PostWriter.ENCODING is > used. > > Finally, regarding this code in HttpRequestHdr: > if (firstLine && !CharUtils.isAscii((char) x)){// includes \n > throw new IllegalArgumentException("Only ASCII > supported in headers (perhaps SSL was used?)"); > } > > > Does it take into account this: > > > - http://tools.ietf.org/html/rfc2231 No, but it's only checking the first line. > > Regards > Philippe
