Hello, Rainer, in which German Town will ApacheCon occur ? Milamber, I live in North of France near Lille (Chti :-) ) (Wilkommen bei den Chti's for Rainer :-) ), rarely going to Paris but could be an occasion but not for signing Key as I don't know the process, Rainer what is it exactly ?
Thanks Regards Philippe On Sun, May 20, 2012 at 10:34 PM, Milamber <milam...@apache.org> wrote: > > > Le 20/05/2012 13:01, Rainer Jung a ecrit : > > On 19.05.2012 19:11, Milamber wrote: > >> [ X] +1 I support this release > >> [ ] +0 I am OK with this release > >> [ ] -0 OK, but.... > >> [ ] -1 I do not support this release (please indicate why) > > > > +1 for release. > > > > Some minor observations, roughly the same as last time plus some other > > details for the yen sign problem, small new problems for collapse.png > > and expand.png and some "2.6" string in a subversion file which was > > fixed in the distribution file. > > > > Thanks for RM! > > And thanks for your review! > > > > > Details: > > > > - MD5 OK > > - signatures OK > > - key in KEYS file > > - AFAIK the key is still not in the web of trust. It would be good > > if we found a way to sign your key. > > Maybe during ApacheCon EU in November? > > Yes, since I have been promoted as a Committer/PMC, I haven't found > opportunity to find someone to sign my key. > I note the date of ApacheCon EU in my calendar, if I can I will go > (depends work constraint and money) (NB. I'm living in Morocco) > Otherwise, next time that I will going to Paris (I pass to 1 or 2 times > by year for work), perhaps I can view a french ASF committer (Philippe?) > > Milamber > > - gz and zip for src and bin consistent apart from: > > - Files extras/collapse.png and extras/expand.png differ > > (the ones in the zip are bigger, gz and svn look the same, > > I guess some unintended conversion happened). > > Those files are not part of the distribution if I build it myself. > > Not a blocker, should be fixed before next time. > > - File printable_docs/usermanual/functions.html again the yen sign > > in line 3531. File says it is ISO-8859-1 encoded, File in gz > > looks OK (and like the docs one in svn), file in zip has > > a multibyte character instead of decimal 165. When I rebuild JMeter > > myself, the yen sign looks right in both files, so seems the > > be an issue with build environment or process. > > Not a blocker. > > > > - src consistent with svn tag, except for the following points: > > > > - File xdocs/overview.html contains "2.6" in svn but "2.7" in > > distribution archives > > > > Only in svn/extras: collapse.png > > Only in svn/extras: expand.png > > > > Already observed for 2.6 > > (and I won't mention them for the next release): > > > > Only in gz/bin/testfiles: Sample_Chart.png > > Only in gz/bin/testfiles: Sample_Line_Graph.png > > Quoting sebb said: Those are test output files; should probably be > > excluded in future. Or they should get created elsewhere. > > > > Only in svn: doap_JMeter.rdf > > Quoting sebb: That's normal for many projects. > > Possibly should find somewhere else to keep the doap - it's only > > really useful for the projects.a.o site as it gets updated after the > > release. > > > > Only in svn: rat-excludes.txt > > Quoting sebb: That's only used by buildbot. > > > > - File permissions in svn and src distribution (OK in bin distribution) > > > > - extras/proxycert.sh and bin/*.sh files not executable > > in svn and src distribution > > - bin/jmeter, bin/jmeter-server and xdocs/download_jmeter.cgi > > files not executable in src distribution (but they are in svn) > > > > - builds fine > > > > - build result looks consistent with distribution, except for > > - timestamps in generated javadoc (expected) > > - binary jar files (expected) > > - yen sign in printable_docs/usermanual/functions.html OK now in > > my own build (wasn't in 2.6) > > - missing /extras/collapse.png and extras/expand.png (see above) > > > > - no Javadoc warnings > > > > - ran the tests (but only with java.awt.headless) > > > > - I have not checked the staging repository. > > > > Build and tests were done using Java 1.5.0_22, OS was Solaris 10 Sparc, > > > > Regards, > > > > Rainer > > > > > > -- Cordialement. Philippe Mouawad.
