Hey Kurt, I have always attached my source diffs to a bug and then replied here with the bug number. One of the devs with commit rights will review, give feedback if needed, and merge if all is well.
The normal gotcha is the documentation updates. Hope this helps, Anthony From: Kurt Hong Sent: 11/30/2012 11:56 AM To: [email protected] Subject: A patch for TCP Sampler Dear apache jmeter developers, I'm warring if these questions would make you feel like a burden as I'm not familiar with open source committing process. I’m reading most of your documents though. If you advise several URL or document, that would be very helpful too. Questions, 1. Once I make a path following http://wiki.apache.org/jmeter/CommittingChanges page, how can I commit that? I mean, can I commit that without svn account? As anonymous account? 2. Or should I discuss enough here in this mailing list before make a commit? 3. In case of modification of documents, in below case, modification of Component Reference.xml is enough? And xUnit test case is mandatory? I made a patch about TCP Sampler and TCP Sampler Config like shown below. On TCP Sampler Config - Add “SO_LINGER” checkbox and “LINGER Timeout” text input box to prevent large numbers of sockets sitting around with a TIME_WAIT status. It’s related to https://issues.apache.org/bugzilla/show_bug.cgi?id=40499 - Add “End of line(EOL) byte value” text input box to set eolByte value on GUI. Setting on GUI will overwrite the setting in properties file. If user doesn’t set the value on GUI, It will use the setting on properties file. On TCP Sampler - Add “Close Connection” checkbox to be able to close connection even if user checks “Re-Use Connection” option. In our company’s test, we needed to close the connection at the end of each thread Also, I’m thinking of moving all checkboxes on TCP Sampler into TCP Sampler Config or Removing “Re-Use Connection” and “Close Connection” checkboxes from TCP Sampler. And this patch was originally made for our company’s testing. Thank you!
