On 14 October 2013 22:05, Philippe Mouawad <[email protected]> wrote: > The problem is that if you change it , then automatically it will change > behaviour of current scripts I think.
Yes. > As when reloading existing script, > getPropertyAsBoolean(INCLUDE_TIMERS, DEFAULT_VALUE_FOR_INCLUDE_TIMERS); > will return DEFAULT_VALUE_FOR_INCLUDE_TIMERS , which will be false while in > fact while its previous meaning when user saved his script was true. The value of the default cannot be changed without affecting existing test plans. > See https://issues.apache.org/bugzilla/show_bug.cgi?id=55498 > > In my opinion this should be changed adding an Incompatible change but we > would need to accept that users who really need it have to modify their > script. > > +1 for this breaking change. > > Regards > Philippe > > > > > On Mon, Oct 14, 2013 at 10:56 PM, Milamber <[email protected]> wrote: > >> >> Le 14/10/2013 21:47, [email protected] a ecrit : >> >> Author: pmouawad >>> Date: Mon Oct 14 20:47:58 2013 >>> New Revision: 1532085 >>> >>> URL: http://svn.apache.org/r1532085 >>> Log: >>> Add constant >>> >> >> Perhaps, It would be great to transform this default value to a property >> for allow user to change this. >> >> >> >> >> >>> Modified: >>> jmeter/trunk/src/core/org/**apache/jmeter/control/** >>> TransactionController.java >>> >>> Modified: jmeter/trunk/src/core/org/**apache/jmeter/control/** >>> TransactionController.java >>> URL: http://svn.apache.org/viewvc/**jmeter/trunk/src/core/org/** >>> apache/jmeter/control/**TransactionController.java?** >>> rev=1532085&r1=1532084&r2=**1532085&view=diff<http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/control/TransactionController.java?rev=1532085&r1=1532084&r2=1532085&view=diff> >>> ==============================**==============================** >>> ================== >>> --- >>> jmeter/trunk/src/core/org/**apache/jmeter/control/**TransactionController.java >>> (original) >>> +++ >>> jmeter/trunk/src/core/org/**apache/jmeter/control/**TransactionController.java >>> Mon Oct 14 20:47:58 2013 >>> @@ -53,6 +53,8 @@ public class TransactionController exten >>> private static final Logger log = LoggingManager.** >>> getLoggerForClass(); >>> + private static final boolean DEFAULT_VALUE_FOR_INCLUDE_**TIMERS = >>> true; // default true for compatibility >>> + >>> /** >>> * Only used in parent Mode >>> */ >>> @@ -293,7 +295,7 @@ public class TransactionController exten >>> * @param includeTimers >>> */ >>> public void setIncludeTimers(boolean includeTimers) { >>> - setProperty(INCLUDE_TIMERS, includeTimers, true); // default >>> true for compatibility >>> + setProperty(INCLUDE_TIMERS, includeTimers, >>> DEFAULT_VALUE_FOR_INCLUDE_**TIMERS); >>> } >>> /** >>> @@ -302,6 +304,6 @@ public class TransactionController exten >>> * @return boolean (defaults to true for backwards compatibility) >>> */ >>> public boolean isIncludeTimers() { >>> - return getPropertyAsBoolean(INCLUDE_**TIMERS, true); >>> + return getPropertyAsBoolean(INCLUDE_**TIMERS, >>> DEFAULT_VALUE_FOR_INCLUDE_**TIMERS); >>> } >>> } >>> >>> >>> >>> >> > > > -- > Cordialement. > Philippe Mouawad.
