The problem is that reverting to r1542839 breaks the code on Windows and FreeBSD.
What status does MacOS report? On 23 November 2013 18:56, Philippe Mouawad <[email protected]> wrote: > -1 as per my previous comment > > On Saturday, November 23, 2013, wrote: > >> Author: sebb >> Date: Sat Nov 23 18:16:53 2013 >> New Revision: 1544856 >> >> URL: http://svn.apache.org/r1544856 >> Log: >> Revert r1542839 >> >> Modified: >> jmeter/trunk/src/jorphan/org/apache/jorphan/exec/KeyToolUtils.java >> >> Modified: >> jmeter/trunk/src/jorphan/org/apache/jorphan/exec/KeyToolUtils.java >> URL: >> http://svn.apache.org/viewvc/jmeter/trunk/src/jorphan/org/apache/jorphan/exec/KeyToolUtils.java?rev=1544856&r1=1544855&r2=1544856&view=diff >> >> ============================================================================== >> --- jmeter/trunk/src/jorphan/org/apache/jorphan/exec/KeyToolUtils.java >> (original) >> +++ jmeter/trunk/src/jorphan/org/apache/jorphan/exec/KeyToolUtils.java Sat >> Nov 23 18:16:53 2013 >> @@ -395,8 +395,12 @@ public class KeyToolUtils { >> arguments.add(keytoolPath); >> arguments.add("-help"); // $NON-NLS-1$ >> try { >> - int status = nativeCommand.run(arguments); >> - return status == 0; >> + /* >> + * Don't check status return. >> + * Some implementations of keytool return non-zero status for >> -help >> + */ >> + nativeCommand.run(arguments); >> + return true; >> } catch (IOException ioe) { >> return false; >> } catch (InterruptedException e) { >> >> >> > > -- > Cordialement. > Philippe Mouawad.
