Thanks, And what about resetter , Is it for what I said ? Thanks
On Sun, Feb 16, 2014 at 4:16 PM, sebb <seb...@gmail.com> wrote: > On 16 February 2014 14:06, Philippe Mouawad <philippe.moua...@gmail.com> > wrote: > > ((AbstractHttpClient) > > httpClient).addResponseInterceptor(METRICS_SAVER); // HACK > > > > Any clarification about this hack ? > > > > I understand METRICS_SAVER saves metrics as another attribute name, but > why > > as it should be available under ((HttpConnection) > > context.getAttribute(ExecutionContext.HTTP_CONNECTION).getMetrics(); > > And METRICS_RESETTER resets these metrics. > > > > I suppose the reset is to have metrics per sample but some comments would > > be useful to clarify exactly: > > - Why we need to reset, is it only to have it per sample ? this can be an > > issue as we loose information like number of requests ... > > - Why we need to have METRICS_SAVER, was it some due to a temporary bug > or > > missing feature in HTTPClient 4 at time of writing ? > > It's a missing feature. > > See https://issues.apache.org/jira/browse/HTTPCLIENT-1081 > > > Regards > > Philippe > > > > > > On Sun, Feb 16, 2014 at 2:48 PM, Philippe Mouawad < > > philippe.moua...@gmail.com> wrote: > > > >> Hello, > >> Looking at code of HTTPHC4Impl, I see this: > >> > >> private static final String CONTEXT_METRICS = "jmeter_metrics"; // > >> TODO hack, to be removed later > >> > >> > >> -- > >> Cordialement. > >> Philippe Mouawad. > >> > >> > >> > > > > > > -- > > Cordialement. > > Philippe Mouawad. > -- Cordialement. Philippe Mouawad.
