On Thu, Oct 9, 2014 at 3:26 AM, sebb <[email protected]> wrote:
> On 8 October 2014 21:57, <[email protected]> wrote:
> > Author: pmouawad
> > Date: Wed Oct 8 20:57:40 2014
> > New Revision: 1630231
> >
> > URL: http://svn.apache.org/r1630231
> > Log:
> > Warn when configuration error (related to 57068)
> >
> > Modified:
> > jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
> >
> > Modified: jmeter/trunk/src/core/org/apache/jmeter/JMeter.java
> > URL:
> http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/JMeter.java?rev=1630231&r1=1630230&r2=1630231&view=diff
> >
> ==============================================================================
> > --- jmeter/trunk/src/core/org/apache/jmeter/JMeter.java (original)
> > +++ jmeter/trunk/src/core/org/apache/jmeter/JMeter.java Wed Oct 8
> 20:57:40 2014
> > @@ -1042,6 +1042,12 @@ public class JMeter implements JMeterPlu
> > };
> > daemon.setDaemon(true);
> > daemon.start();
> > + } else if(REMAIN_THREAD_PAUSE<0) {
> > + throw new IllegalArgumentException("Configured
> jmeter.exit.check.pause is negative:"+REMAIN_THREAD_PAUSE);
>
> -1
>
> That changes the behaviour unnecessarily, and is contrary to the
> comment in jmeter.properties:
>
Good catch, fixed, thanks
>
> # If the value is <= 0, the JMeter does not start the daemon thread
>
> > + } else {
> > + if(log.isDebugEnabled()) {
> > + log.debug("jmeter.exit.check.pause is set to 0, no
> wait for thread ends");
>
> This is OK, but needs to be reworded to fit the new conditions, for
> example:
>
> log.debug("jmeter.exit.check.pause is <=0, JMeter won't check for
> unterminated non-daemon threads");
>
> > + }
> > }
> > }
> >
> >
> >
>
--
Cordialement.
Philippe Mouawad.
