Hi, I commited patch with exception of LogFunction2 synchronized removal on execute.
@All, as this change is touchy, I suggest you all do a code review and possibly tests to ensure we don't break anything with it. My analysis on this leads me to think it is OK, tests I ran on Javascript function didn't show any issue except the following which seems to be related to Eclipse Debugger/ Or Java (Tried Last java7, Last Java 8 and Last JAva 6): - I ran test, in debug mode, with new code, at end of test CPU is at 11% and does not decrease. Running it in Run Mode , it is OK. Doing thread dump (with debug mode) , I don't see anything in JMeter internals. Regards Philippe On Sun, Oct 19, 2014 at 9:42 PM, Philippe Mouawad < [email protected]> wrote: > Hello Vladimir, > Thanks for contribution. > For 2, 3 you can open a bugzilla and attach patch. > > > I reviewed the patch, look OK for me, but why don't you also synchronize > LogFunction2#execute since you do for LogFunction#execute ? > > Thanks > > On Sat, Oct 18, 2014 at 4:44 PM, Vladimir Sitnikov < > [email protected]> wrote: > >> Thanks for creating a bug id. I've attached the patch. >> >> What is the preferred way to handle small improvements like 2 and 3? >> >> Vladimir Sitnikov >> > > > > -- > Cordialement. > Philippe Mouawad. > > > -- Cordialement. Philippe Mouawad.
