Am 05.11.2014 um 23:17 schrieb Milamber:
Hello,

The second release candidate for JMeter 2.12 (r1636949) has been
prepared, and your votes are solicited.
...

All feedback and vote are welcome.
        
[XX] +1  I support this release
[  ] +0  I am OK with this release
[  ] -0   OK, but....
[  ] -1   I do not support this release (please indicate why)

+1 (binding), thanks for RM.

Details:

- MD5 OK
- signatures OK
- key in KEYS file
- gz and zip for src and bin consistent
- svn and gz/zip mostly consistent
  - "bin/mirror-server" missing from dist,
    not a showstopper, since mirror-server.sh
    is included and mirror-server is only a trivial wrapper
    Fixed in svn by r1637321.
  - Revision number in line
    <property name="version.build" value="$Revision: 1634702 $"/>
    (expected)
- builds fine
- build result looks consistent with distribution, except for
  - timestamps in generated javadoc (expected)
    - should we exclude those? Javadoc has a flag to
      not generate the timestamps.
  - some whitespace in javadoc (expected)
  - binary jar files (expected)
- no Javadoc warnings when building with Java 6 or 7
- some Javadoc warnings when building with Java 8
  - Details see below
- ran the tests (but only with java.awt.headless)
- I have not checked the staging repository.
- I have not checked tha rat report

Build and tests were done using Java 1.6.0_45, 1.7.0_51 and 1.8.0, OS was Solaris 10 Sparc.

Javadoc Warnings under Java 8:

/src/core/org/apache/jmeter/JMeter.java:274: warning: no @param for args
/src/core/org/apache/jmeter/JMeter.java:847: warning: no description for @param /src/reports/org/apache/jmeter/JMeterReport.java:299: warning: no description for @param /src/core/org/apache/jmeter/NewDriver.java:190: warning: no description for @param /src/core/org/apache/jmeter/NewDriver.java:200: warning: no description for @throws /src/core/org/apache/jmeter/util/BeanShellTestElement.java:137: warning: no description for @throws /src/core/org/apache/jmeter/testelement/TestElement.java:79: warning: no @return /src/core/org/apache/jmeter/testelement/TestElement.java:85: warning: no description for @param /src/core/org/apache/jmeter/testelement/TestElement.java:102: warning: no @param for key /src/core/org/apache/jmeter/testelement/TestElement.java:102: warning: no @return /src/core/org/apache/jmeter/testelement/TestElement.java:126: warning: no @param for run /src/core/org/apache/jmeter/testelement/TestElement.java:149: warning: no @param for property /src/core/org/apache/jmeter/testelement/TestElement.java:155: warning: no @param for propName /src/core/org/apache/jmeter/testelement/TestElement.java:155: warning: no @return /src/core/org/apache/jmeter/testelement/TestElement.java:173: warning: no @param for traverser /src/core/org/apache/jmeter/gui/Searchable.java:29: warning: no description for @throws /src/core/org/apache/jmeter/testelement/AbstractScopedTestElement.java:71: warning: no description for @param /src/core/org/apache/jmeter/testelement/AbstractScopedTestElement.java:81: warning: no description for @param /src/core/org/apache/jmeter/testelement/AbstractScopedTestElement.java:91: warning: no description for @param /src/core/org/apache/jmeter/testelement/AbstractScopedTestElement.java:101: warning: no description for @param /src/components/org/apache/jmeter/assertions/HTMLAssertion.java:260: warning: no description for @param /src/components/org/apache/jmeter/assertions/HTMLAssertion.java:273: warning: no description for @param /src/components/org/apache/jmeter/assertions/HTMLAssertion.java:282: warning: no description for @param /src/components/org/apache/jmeter/assertions/HTMLAssertion.java:298: warning: no description for @param /src/components/org/apache/jmeter/assertions/HTMLAssertion.java:371: warning: no description for @param /src/core/org/apache/jmeter/util/JSR223TestElement.java:135: warning: no description for @throws /src/core/org/apache/jmeter/util/JSR223TestElement.java:136: warning: no description for @throws /src/components/org/apache/jmeter/assertions/SizeAssertion.java:113: warning: no @return /src/components/org/apache/jmeter/assertions/SizeAssertion.java:120: warning: no @param for operator /src/components/org/apache/jmeter/assertions/SizeAssertion.java:130: warning: no @return /src/components/org/apache/jmeter/assertions/XPathAssertion.java:159: warning: no description for @param /src/components/org/apache/jmeter/assertions/XPathAssertion.java:168: warning: no description for @param /src/components/org/apache/jmeter/assertions/XPathAssertion.java:177: warning: no description for @param /src/core/org/apache/jmeter/gui/AbstractScopedJMeterGuiComponent.java:91: warning: no description for @param /src/core/org/apache/jmeter/gui/AbstractScopedJMeterGuiComponent.java:110: warning: no description for @param /src/core/org/apache/jmeter/gui/AbstractScopedJMeterGuiComponent.java:119: warning: no description for @param /src/core/org/apache/jmeter/gui/AbstractScopedJMeterGuiComponent.java:120: warning: no description for @param /src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java:96: warning: no @param for comment /src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java:135: warning: no @return /src/components/org/apache/jmeter/assertions/gui/HTMLAssertionGui.java:170: warning: no description for @param /src/components/org/apache/jmeter/assertions/gui/HTMLAssertionGui.java:268: warning: no description for @param /src/components/org/apache/jmeter/assertions/gui/HTMLAssertionGui.java:313: warning: no @param for e /src/components/org/apache/jmeter/assertions/gui/SizeAssertionGui.java:155: warning: no @param for state /src/components/org/apache/jmeter/assertions/gui/SizeAssertionGui.java:180: warning: no @return /src/components/org/apache/jmeter/assertions/gui/XPathPanel.java:94: warning: no description for @param /src/components/org/apache/jmeter/assertions/gui/XPathPanel.java:112: warning: no description for @param /src/core/org/apache/jmeter/config/gui/RowDetailDialog.java:234: warning: no description for @param /src/core/org/apache/jmeter/control/Controller.java:53: warning: no @param for listener /src/components/org/apache/jmeter/control/CriticalSectionController.java:95: warning: no @param for name /src/core/org/apache/jmeter/control/GenericController.java:210: warning: no description for @param /src/core/org/apache/jmeter/control/GenericController.java:220: warning: no description for @param /src/core/org/apache/jmeter/control/GenericController.java:222: warning: no description for @throws /src/core/org/apache/jmeter/control/GenericController.java:238: warning: no description for @param /src/core/org/apache/jmeter/control/GenericController.java:240: warning: no description for @throws /src/core/org/apache/jmeter/control/GenericController.java:252: warning: no description for @throws /src/core/org/apache/jmeter/control/GenericController.java:305: warning: no description for @param /src/core/org/apache/jmeter/control/GenericController.java:306: warning: no description for @throws /src/core/org/apache/jmeter/threads/TestCompilerHelper.java:42: warning: no description for @param /src/components/org/apache/jmeter/control/CriticalSectionController.java:87: warning: no @param for name /src/core/org/apache/jmeter/control/IfController.java:86: warning: no @param for condition /src/core/org/apache/jmeter/control/IfController.java:93: warning: no @return /src/core/org/apache/jmeter/control/IfController.java:78: warning: no @param for condition /src/components/org/apache/jmeter/control/IncludeController.java:87: warning: no description for @param /src/components/org/apache/jmeter/control/IncludeController.java:122: warning: no @return /src/core/org/apache/jmeter/control/ReplaceableController.java:38: warning: no @return /src/core/org/apache/jmeter/control/ReplaceableController.java:43: warning: no description for @param /src/components/org/apache/jmeter/control/ModuleController.java:132: warning: no description for @param /src/core/org/apache/jmeter/control/TransactionController.java:308: warning: no description for @param /src/core/org/apache/jmeter/samplers/SampleListener.java:32: warning: no @param for e /src/core/org/apache/jmeter/samplers/SampleListener.java:37: warning: no @param for e /src/core/org/apache/jmeter/samplers/SampleListener.java:42: warning: no @param for e /src/core/org/apache/jmeter/samplers/Sampler.java:36: warning: no @param for e
/src/core/org/apache/jmeter/samplers/Sampler.java:36: warning: no @return
/src/core/org/apache/jmeter/engine/TreeCloner.java:59: warning: no description for @param /src/core/org/apache/jmeter/functions/Function.java:40: warning: no @param for previousResult /src/core/org/apache/jmeter/functions/Function.java:40: warning: no @param for currentSampler
/src/core/org/apache/jmeter/functions/Function.java:40: warning: no @return
/src/core/org/apache/jmeter/functions/Function.java:40: warning: no @throws for org.apache.jmeter.functions.InvalidVariableException /src/core/org/apache/jmeter/functions/Function.java:48: warning: no description for @param /src/core/org/apache/jmeter/functions/Function.java:49: warning: no description for @throws
/src/core/org/apache/jmeter/functions/Function.java:57: warning: no @return
/src/core/org/apache/jmeter/functions/Function.java:69: warning: no @return
/src/core/org/apache/jmeter/engine/util/ValueTransformer.java:42: warning: no description for @param /src/core/org/apache/jmeter/engine/util/ValueTransformer.java:50: warning: no description for @param /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:67: warning: no description for @param /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:68: warning: no description for @throws /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:85: warning: no description for @param /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:86: warning: no description for @throws /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:96: warning: no description for @param /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:97: warning: no description for @param /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:98: warning: no description for @throws /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:108: warning: no description for @param /src/core/org/apache/jmeter/engine/util/ValueReplacer.java:109: warning: no description for @throws /src/functions/org/apache/jmeter/functions/FileWrapper.java:181: warning: no description for @param /src/core/org/apache/jmeter/gui/GuiPackage.java:676: warning: no description for @param /src/core/org/apache/jmeter/gui/GuiPackage.java:761: warning: no description for @param /src/core/org/apache/jmeter/gui/GuiPackage.java:779: warning: no description for @param /src/core/org/apache/jmeter/gui/MainFrame.java:819: warning: no description for @param /src/core/org/apache/jmeter/gui/MainFrame.java:820: warning: no description for @param /src/reports/org/apache/jmeter/gui/ReportGuiPackage.java:603: warning: no description for @param

Regards,

Rainer

Reply via email to