You never know :) Sometimes a slight corr change can break things. As this is really core and critical part, it doesn't hurt to mention it.
Regards On Monday, December 22, 2014, sebb <[email protected]> wrote: > On 22 December 2014 at 18:31, Philippe Mouawad > <[email protected] <javascript:;>> wrote: > > If you add a Bugzilla, it will be in changes.html so users see it. > > while here only subscriber to commits will see it. > > Yes, but is this particular change likely to be relevant to end users? > I'm not sure the NPE can occur in normal use. > > > > > > > On Monday, December 22, 2014, sebb <[email protected] <javascript:;>> > wrote: > > > >> On 22 December 2014 at 17:05, Philippe Mouawad > >> <[email protected] <javascript:;> <javascript:;>> wrote: > >> > Hi, > >> > I prefer if possible to open a Bugzilla, as this kind of change can be > >> > impacting and sometimes you notice issues few months after but don't > >> > remember this change. > >> > >> I don't see how a Bugzilla helps here, so long as the log message is > clear. > >> > >> I would not expect to raise a Bugzilla for trivial spelling errors, > >> nor tab removal. > >> Nor is it always necessary for simple changes such as converting magic > >> numbers or strings to private constants. > >> > >> > This is particularly needed for Third Party providers. > >> > >> What do you mean by that? > >> > >> > Regards > >> > Philippe > >> > > >> > On Mon, Dec 22, 2014 at 5:57 PM, sebb <[email protected] > <javascript:;> <javascript:;>> > >> wrote: > >> > > >> >> On 22 December 2014 at 16:34, Felix Schumacher > >> >> <[email protected] <javascript:;> <javascript:;>> > wrote: > >> >> > Hi all, > >> >> > > >> >> > in the converters in org.apache.jmeter.save.converters there are a > few > >> >> > possible NPE. In the method canConvert(Class) often the > implementation > >> >> looks > >> >> > like > >> >> > > >> >> > "return arg0.equals(SomeClass.class)" > >> >> > > >> >> > without arg0 being checked for non-null. > >> >> > > >> >> > I have a patch, that reverts the logic to > >> >> > > >> >> > "return SomeClass.class.equals(arg0)" > >> >> > > >> >> > This is null safe and should return the same values (apart from > >> possible > >> >> > NPE). > >> >> > > >> >> > Can I check those changes in whithout creating a bugzilla entry? > >> >> > >> >> OK by me. > >> >> > >> >> Please ensure that the commit only contains these specific changes, > >> >> and not any unrelated ones. > >> >> Thanks. > >> >> > >> >> > Regards > >> >> > Felix > >> >> > >> > > >> > > >> > > >> > -- > >> > Cordialement. > >> > Philippe Mouawad. > >> > > > > > > -- > > Cordialement. > > Philippe Mouawad. > -- Cordialement. Philippe Mouawad.
