+1 I see no reasons not to do it.
-- Andrey Pokhilko On 01/24/2015 06:30 PM, Philippe Mouawad wrote: > Hello, > It appears 2.12 suffers from an OOM in GUI mode : > > - https://issues.apache.org/bugzilla/show_bug.cgi?id=57440 > > This OOM seems to be due to RSyntaxTexarea bug: > > - https://github.com/bobbylight/RSyntaxTextArea/issues/99 > > It appeared after the rework of LoggerPanel#processEvent way of appending > event. > > Now that it receivs log event even when closed this OOM has more chances to > appear. > > I reverted to 2.11 way of appending events to fix OOM waiting for answer > from rsyntaxtarea project. > > There was also a bug in the way limit=0 was set that had no effect, I fixed > it as part of the bug. > > There is a workaround which is to set: > > - jmeter.loggerpanel.enable_when_closed=false > > But if user opens panel, OOM will occur if lot of logs occur (specially if > stacktraces). > > If we release, it cannot be named 2.12.1 because we have some "big?" > features in this versions so it would not be a minor one. > > Regarding the frequency and impact of this bug, in our company I had 2 > reports in 5 days of this OOM so I think it is not to be ignored. > > > Thoughts ? >
