HI Philippe, Thanks for reviewing, I addressed all your suggestions: - properties prefix is "client", just like other properties of similar purpose - changed comments inside jmeter.properties file - changed all 'host' in code into 'address'
Andrey Pokhilko On 01/27/2015 01:20 AM, Philippe Mouawad wrote: > Hi, > I reviewed it, looks nice. > > Some notes: > > - rmi prefix should maybe replaced by something more "functional" like > distributed_runner > - properties in jmeter.properties should be commented > - host in code is in fact hostAndPort no ? Maybe rename it > > That's it for now. > > Regards > > Philippe > > On Mon, Jan 26, 2015 at 4:35 PM, Andrey Pokhilko <[email protected]> wrote: > >> Hello, >> >> I'd like to commit the change to have retries with remote testing and >> ability to ignore failed nodes and proceed. This will allow to have >> large-scale tests still running in non-ideal infrastructure of clouds >> (eg AWS), where some VMs might fail to fire up. The defaults not use >> this feature, it is available through property settings. >> >> PR for review: https://github.com/apache/jmeter/pull/13 >> Bugzilla: https://issues.apache.org/bugzilla/show_bug.cgi?id=57500 >> >> Please review it. I'll add documentation changes once we'll discuss and >> fix the initial issues of the code. >> >> -- >> Andrey Pokhilko >> >> >
