Re: UBIKLOADPACK JSON PLUGIN DONATION TO APACHE JMETER

Sat, 17 Oct 2015 05:19:14 -0700 


On 17/10/2015 12:46, Felix Schumacher wrote:

Am 17.10.2015 um 09:25 schrieb UBIK LOAD PACK Support:

Hello,

I thought initial idea was to submit the code AS-IS and wait for the 
vote,

so I didn't tidy everything up.

Anyway, now it's the case:

- Fixed JUnits (Although I touched the Junit Test case, it was only 
to fix

a typo in method name, not change the test)
* Added Maven dependencies
* Modified eclipse.classpath
* updated saveservices.properties and SaveService.java
* Added documentation section as per JMeter convention and screenshot

Well, you might have noticed, that I spammed the list with comments on 
your pr.


Yes it's a good spam. :-) Big peer review, thanks.




It looks good to me.

Thanks for the work,
 Felix



Regards
@ubikloadpack

On Fri, Oct 16, 2015 at 9:35 PM, Milamber <[email protected]> wrote:



On 16/10/2015 12:39, UBIK LOAD PACK Support wrote:


Hi Felix, All,

We submitted:

     - https://github.com/apache/jmeter/pull/28

Shall we create a Bugzilla ?


Probably that is a good idea.

Test the PR28 with ant test show some errors on tests:

      [java] There were 7 failures:
      [java] 1)

testMaven(org.apache.jmeter.JMeterVersionTest)junit.framework.AssertionFailedError: 


Should have no names left: [json-smart, json-path]. Check
ApacheJMeter_parent.pom
      [java]     at

org.apache.jmeter.JMeterVersionTest.testMaven(JMeterVersionTest.java:189) 


      [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
      [java]     at

sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 


      [java]     at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 

      [java]     at 
org.apache.jorphan.test.AllTests.main(AllTests.java:236)

      [java] 2)

testEclipse(org.apache.jmeter.JMeterVersionTest)junit.framework.AssertionFailedError: 


Should have no names left: [json-smart]. Check eclipse.classpath
      [java]     at

org.apache.jmeter.JMeterVersionTest.testEclipse(JMeterVersionTest.java:160) 


      [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
      [java]     at

sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 


      [java]     at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 

      [java]     at 
org.apache.jorphan.test.AllTests.main(AllTests.java:236)

      [java] 3)

GUIComponents1(org.apache.jmeter.junit.JMeterTest)junit.framework.AssertionFailedError: 


SaveService nameMap (saveservice.properties) should contain
org.apache.jmeter.extractor.json.jsonpath.gui.JSONPostProcessorGui
      [java]     at

org.apache.jmeter.junit.JMeterTest.checkElementAlias(JMeterTest.java:553) 


      [java]     at
org.apache.jmeter.junit.JMeterTest.GUIComponents1(JMeterTest.java:434)

      [java]     at 
sun.reflect.GeneratedMethodAccessor25.invoke(Unknown

Source)
      [java]     at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 

      [java]     at 
org.apache.jorphan.test.AllTests.main(AllTests.java:236)

      [java] 4)

runGUITitle(org.apache.jmeter.junit.JMeterTest)junit.framework.AssertionFailedError: 


component_reference.xml needs 'JSON-PATH_PostProcessor' anchor for
org.apache.jmeter.extractor.json.jsonpath.gui.JSONPostProcessorGui
      [java]     at
org.apache.jmeter.junit.JMeterTest.runGUITitle(JMeterTest.java:368)

      [java]     at 
sun.reflect.GeneratedMethodAccessor27.invoke(Unknown

Source)
      [java]     at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 

      [java]     at 
org.apache.jorphan.test.AllTests.main(AllTests.java:236)

      [java] 5)

runTestElement(org.apache.jmeter.junit.JMeterTest)junit.framework.AssertionFailedError: 


SaveService nameMap (saveservice.properties) should contain
org.apache.jmeter.extractor.json.jsonpath.JSONPostProcessor
      [java]     at

org.apache.jmeter.junit.JMeterTest.checkElementAlias(JMeterTest.java:553) 


      [java]     at
org.apache.jmeter.junit.JMeterTest.runTestElement(JMeterTest.java:540)

      [java]     at 
sun.reflect.GeneratedMethodAccessor37.invoke(Unknown

Source)
      [java]     at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 

      [java]     at 
org.apache.jorphan.test.AllTests.main(AllTests.java:236)

      [java] 6)

testRenderResultWithLongStringBug54826(org.apache.jmeter.visualizers.TestRenderAsJson)junit.framework.ComparisonFailure: 


expected:<{
      [java] [:]   "customData":"som...> but was:<{
      [java] [ ]   "customData":"som...>
      [java]     at

org.apache.jmeter.visualizers.TestRenderAsJson.testRenderResultWithLongStringBug54826(TestRenderAsJson.java:35) 


      [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
      [java]     at

sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 


      [java]     at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 

      [java]     at 
org.apache.jorphan.test.AllTests.main(AllTests.java:236)

      [java] 7)

testRenderResultSimpleStructur(org.apache.jmeter.visualizers.TestRenderAsJson)junit.framework.ComparisonFailure: 


expected:<{
      [java] [:   "Hello": "World",
      [java] :   "more":
      [java] :   [
      [java] :   :   "Something",
      [java] :   :   "else",
      [java] :]   ]
      [java] }> but was:<{
      [java] [    "Hello": "World",
      [java]     "more":
      [java]     [
      [java]         "Something",
      [java]         "else",
      [java]  ]   ]
      [java] }>
      [java]     at

org.apache.jmeter.visualizers.TestRenderAsJson.testRenderResultSimpleStructur(TestRenderAsJson.java:61) 


      [java]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
      [java]     at

sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) 


      [java]     at

sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 

      [java]     at 
org.apache.jorphan.test.AllTests.main(AllTests.java:236)

      [java]
      [java] FAILURES!!!
      [java] Tests run: 2550,  Failures: 7,  Errors: 0
      [java]






Regards
UbikLoadPack Team
@ubikloadpack

On Thu, Oct 15, 2015 at 11:31 AM, Felix Schumacher <
[email protected]> wrote:

Am 14.10.2015 um 21:05 schrieb UBIK LOAD PACK Support:

Hello Dev Team,

I am contacting you to know if you would be interested in 
integrating

our
JSON Plugin within Core JMeter.

I think json support directly in jmeter is needed.

Its features are shown on our blog, I didn't put any link because 
none of

my 2 previous mails were received on dev mailing list.

I looked at the blog post for which Rainer sent the link.

The features look good. What "language" is the extraction part?


It's based on json-path : http://goessner.net/articles/JsonPath/


Is there any standard like xpath/xquery for xml?

Kind of

Currently plugin uses com.ubikingenierie.loadpack package, but it 
would be

donated with a package you would choose:

- org.apache.jmeter.json for example


Renaming a package is really simple with modern IDEs, so that 
would be a

no-brainer.

Done within PR.

If you are OK and wish to integrate it, we would submit a PR on 
Github so

that you can review it and potentially provide some patches before
integration in JMeter.

Probably a good idea.

Done

Regards,

   Felix

Your feedback is welcome.


We think this feature would be very useful for Web Application 
testing

where JSON format is becoming a very frequently used format for Rest
Webservices for example.

Thanks
Regards
Ubik Load Pack Team
@ubikloadpack































					Reply via email to