Github user pmouawad commented on the pull request:
https://github.com/apache/jmeter/pull/26#issuecomment-160442852
After further analysis, I understand you might be talking about the piece
of code in GraphiteBackendListenerClient#addMetrics
graphiteMetricsManager.addMetric(timestampInSeconds,
contextName, METRIC_OK_COUNT, Integer.toString(metric.getSuccesses()));
graphiteMetricsManager.addMetric(timestampInSeconds, contextName,
METRIC_KO_COUNT, Integer.toString(metric.getFailures()));
graphiteMetricsManager.addMetric(timestampInSeconds, contextName,
METRIC_ALL_COUNT, Integer.toString(metric.getTotal()));
graphiteMetricsManager.addMetric(timestampInSeconds, contextName,
METRIC_ALL_HITS_COUNT, Integer.toString(metric.getHits()));
// See https://bz.apache.org/bugzilla/show_bug.cgi?id=57350
if(metric.getTotal() > 0) {
Which should be maybe:
if(metric.getTotal() > 0) {
graphiteMetricsManager.addMetric(timestampInSeconds,
contextName, METRIC_OK_COUNT, Integer.toString(metric.getSuccesses()));
graphiteMetricsManager.addMetric(timestampInSeconds,
contextName, METRIC_KO_COUNT, Integer.toString(metric.getFailures()));
graphiteMetricsManager.addMetric(timestampInSeconds,
contextName, METRIC_ALL_COUNT, Integer.toString(metric.getTotal()));
graphiteMetricsManager.addMetric(timestampInSeconds,
contextName, METRIC_ALL_HITS_COUNT, Integer.toString(metric.getHits()));
Do I understand well ?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
