I would agree with the cleanup items, actually not sure i see the value in an extras directory. If it is important be in the right place otherwise perhaps something for a wiki / documentation /blog post. But cleaning up first good step.
Regarding jmeter.fb there is an old email list discussion on original inclusion of findbugs - http://osdir.com/ml/jakarta.jmeter.devel/2003-10/msg00391.html But the .fb file itself is a findbugs project file generated from findbugs UI. Per the findbugs documentation *-project* *project* Specify a project to be analyzed. The project file you specify should be one that was created using the GUI interface. It will typically end in the extension .fb or .fbp. In short - it was an extra because you could load this back into FindBugs. The findbugs task in build.xml does not require or need the jmeter.fb it is truly an extra. So for me this opens a few questions a) Is findbugs used in the automated build of JMeter? or is someone using this before a final release? b) Why is the fb-csv.xml and fb-excludes.xml files in the root directory of JMeter Just to confirm it still works I just - started with clean jmeter copy on v2_13 tag, - new download of latest findbugs (into JMETER_SOURCE/findbugs) - configured build.xml setting findbugs.homedir as follows <property name="findbugs.homedir" value="./findbugs" /> - ant - ant findbugs and it does generate the report, though can not yet speak to the details PackageCode SizeBugsHigh Prio BugsMedium Prio BugsLow Prio BugsExp. Bugs RatioOverall (114 packages), (1211 classes)711711186157 On Sun, Dec 13, 2015 at 8:12 AM, Philippe Mouawad < [email protected]> wrote: > Hi, > Any feedback ? > can I drop all the files I mentioned as droppable ? > > What about jmeter.fb ? Anybody knows what it's for ? > > > Thanks > > On Saturday, December 12, 2015, Philippe Mouawad < > [email protected]> > wrote: > > > Hello, > > Looking at extras content I wonder if we should not cleanup some files > and > > document the others: > > > > I suggest we drop those: > > > > - ConvertHTTPSampler.txt => Should we really maintain a migration script > > created for 2.1.1 ? I think we should drop it > > - convertjmx.fdl => Is this still useful ? I don't have openvms to test > > but it seems to me weird > > - execcode.bsh => OS Process Sampler has replaced this no ? > > - jmeter-results-detail-report_21.xsl => Why keep a 2.1 compatible XSL ? > > - jmeter-results-report_21.xsl => Same thing > > - Test.jmx => What is its purpose ? > > - What is jmeter.fb ? > > > > For info: > > - addons.xml was not working anymore and targetting 1.2, fixed > > - addons.txt was wrong, fixed > > > > -- > > Regards. > > Philippe > > > > > > -- > Cordialement. > Philippe Mouawad. > -- Richard Friedman 609.314.0129
