-1 Auto boxing is generally a bad idea as it can hide poor design (wrong choice of long/Long).
It can also hide wrong choice of method (Long.parseLong/Long.decode) Implicit unboxing can hide potential NPE. About the only place where autoboxing is useful is in String.format, but that should not be used as an excuse to allow it elsewhere. On 14 February 2016 at 14:44, ham1 <[email protected]> wrote: > GitHub user ham1 opened a pull request: > > https://github.com/apache/jmeter/pull/123 > > Removing unnecessary (un)boxing > > Removed unnecessary boxing and unboxing of primatives. > Also did a bit of refactoring in AbstractGraphConsumer. > > You can merge this pull request into a Git repository by running: > > $ git pull https://github.com/ham1/jmeter unneccesary_box_unboxing > > Alternatively you can review and apply these changes as the patch at: > > https://github.com/apache/jmeter/pull/123.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > > This closes #123 > > ---- > commit 29fc708b228ca6081a492abc35365e112808beff > Author: Graham Russell <[email protected]> > Date: 2016-02-13T22:20:05Z > > Removing unnecessary (un)boxing - also some other code tidy up while in > some messy areas. > > ---- > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at [email protected] or file a JIRA ticket > with INFRA. > ---
