On 1 March 2016 at 21:02, benbenw <[email protected]> wrote:
> GitHub user benbenw opened a pull request:
>
> https://github.com/apache/jmeter/pull/148
>
> deprecate some methods in JMeterUtils
>
> because creating a button with the netscape style could bring you to jail
>
> You can merge this pull request into a Git repository by running:
>
> $ git pull https://github.com/benbenw/jmeter dilavni
>
> Alternatively you can review and apply these changes as the patch at:
>
> https://github.com/apache/jmeter/pull/148.patch
-1
It's not clear that these should be deprecated.
In any case, the patch is incomplete.
If a method is deprecated, the Javadoc also needs to be updated.
The convention is to document what the user should use instead, and
the version in which the method was deprecated.
For example:
NativeCommand.java: * @deprecated (2.10) use {@link
org.apache.jorphan.exec.SystemCommand} instead
> To close this pull request, make a commit to your master/trunk branch
> with (at least) the following in the commit message:
>
> This closes #148
>
> ----
> commit 67776632f6078fa74927d43e9c47eafceb4c1743
> Author: benoit <[email protected]>
> Date: 2016-03-01T20:52:31Z
>
> deprecate some methods in jmeterutils
> because creating a button with the netscape style could bring you to
> jail
>
> ----
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at [email protected] or file a JIRA ticket
> with INFRA.
> ---
