I see the maintenance issue now. The LICENSE file relies on the contents of licenses/bin to document 3rd party jars. As such, even jars under the AL need a file.
It would be easier for the user - and probably easier to maintain - if the LICENSE file listed all the 3rd party jars by name and version. For jars that are not under AL 2.0 there would need to be a pointer to the license under license/bin. But only distinct licenses would need to be present. When a jar is updated, only the LICENSE file would need to be updated with the new version unless the license also changed. The existing scheme worked OK when there weren't many 3rd party jars. Not sure it's working properly now. Note: we should also list the ASF jar versions in LICENSE to make it easier for users. It would even be possible then to write a test to scan LICENSE looking for jar versions and compare against build.properties. On 17 March 2016 at 20:03, Philippe Mouawad <[email protected]> wrote: > Ok, I understand. > Done > > On Thu, Mar 17, 2016 at 8:52 PM, sebb <[email protected]> wrote: > >> Yes, every 3rd party jar needs to be mentioned in LICENSE >> >> It's important that users have confidence that the code is available >> under the AL. >> If a jar is not mentioned, then it is not obvious whether it is >> compatible or not. >> Users should not have to work out which jars belong to the same project. >> >> On 17 March 2016 at 19:27, Philippe Mouawad <[email protected]> >> wrote: >> > But accessors-smart is part of json-smart: >> > https://github.com/netplex/json-smart-v2 >> > >> > Do I need to add a file for accessort-smart ? >> > >> > This is becoming a bit cumbersome each time we change a version >> > >> > On Thu, Mar 17, 2016 at 8:24 PM, sebb <[email protected]> wrote: >> > >> >> All 3rd party jars need to be mentioned in LICENSE.txt even if they use >> >> AL2.0 >> >> >> >> On 17 March 2016 at 19:22, Philippe Mouawad <[email protected] >> > >> >> wrote: >> >> > Done >> >> > >> >> > On Thu, Mar 17, 2016 at 4:56 PM, sebb <[email protected]> wrote: >> >> > >> >> >> This is a new 3rd party jar. >> >> >> The license needs to be checked for compatibility and if OK must be >> >> >> documented in LICENSE - and stored locally if it is not AL 2.0 >> >> >> >> >> >> >> >> >> On 17 March 2016 at 12:14, <[email protected]> wrote: >> >> >> > Author: pmouawad >> >> >> > Date: Thu Mar 17 12:14:44 2016 >> >> >> > New Revision: 1735407 >> >> >> > >> >> >> > URL: http://svn.apache.org/viewvc?rev=1735407&view=rev >> >> >> > Log: >> >> >> > Bug 59187 - JSON Post Processor : java.lang.NoClassDefFoundError: >> >> >> net/minidev/asm/FieldFilter at >> >> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects >> >> nightly >> >> >> build before 3.0 release) >> >> >> > Bugzilla Id: 59187 >> >> >> > >> >> >> > Modified: >> >> >> > jmeter/trunk/build.properties >> >> >> > jmeter/trunk/build.xml >> >> >> > jmeter/trunk/eclipse.classpath >> >> >> > jmeter/trunk/lib/ (props changed) >> >> >> > jmeter/trunk/lib/aareadme.txt >> >> >> > jmeter/trunk/res/maven/ApacheJMeter_parent.pom >> >> >> > jmeter/trunk/xdocs/changes.xml >> >> >> > >> >> >> > Modified: jmeter/trunk/build.properties >> >> >> > URL: >> >> >> >> >> >> http://svn.apache.org/viewvc/jmeter/trunk/build.properties?rev=1735407&r1=1735406&r2=1735407&view=diff >> >> >> > >> >> >> >> >> >> ============================================================================== >> >> >> > --- jmeter/trunk/build.properties (original) >> >> >> > +++ jmeter/trunk/build.properties Thu Mar 17 12:14:44 2016 >> >> >> > @@ -42,11 +42,21 @@ >> >> >> > >> >> >> > maven2.repo = https://repo1.maven.org/maven2 >> >> >> > >> >> >> > +accessors-smart.version = 1.1 >> >> >> > +accessors-smart.jar = >> >> >> accessors-smart-${accessors-smart.version}.jar >> >> >> > +accessors-smart.loc = >> >> >> ${maven2.repo}/net/minidev/accessors-smart/${accessors-smart.version} >> >> >> > +accessors-smart.md5 = b75cda0d7dadff9e6c20f4e7f3c3bc82 >> >> >> > + >> >> >> > apache-bsf.version = 2.4.0 >> >> >> > apache-bsf.jar = bsf-${apache-bsf.version}.jar >> >> >> > apache-bsf.loc = >> >> >> ${maven2.repo}/bsf/bsf/${apache-bsf.version} >> >> >> > apache-bsf.md5 = 16e82d858c648962fb5c959f21959039 >> >> >> > >> >> >> > +asm.version = 5.1 >> >> >> > +asm.jar = asm-${asm.version}.jar >> >> >> > +asm.loc = >> >> >> ${maven2.repo}/org/ow2/asm/asm/${asm.version} >> >> >> > +asm.md5 = 3770466405f163d6616b65c32e16a3cd >> >> >> > + >> >> >> > avalon-framework.version = 4.1.4 >> >> >> > avalon-framework.jar = >> >> >> avalon-framework-${avalon-framework.version}.jar >> >> >> > avalon-framework.loc = >> >> >> >> >> >> ${maven2.repo}/avalon-framework/avalon-framework/${avalon-framework.version} >> >> >> > >> >> >> > Modified: jmeter/trunk/build.xml >> >> >> > URL: >> >> >> >> >> >> http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=1735407&r1=1735406&r2=1735407&view=diff >> >> >> > >> >> >> >> >> >> ============================================================================== >> >> >> > --- jmeter/trunk/build.xml (original) >> >> >> > +++ jmeter/trunk/build.xml Thu Mar 17 12:14:44 2016 >> >> >> > @@ -360,7 +360,9 @@ >> >> >> > >> >> >> > <!-- Jars for binary release --> >> >> >> > <patternset id="external.jars"> >> >> >> > + <include name="${lib.dir}/${accessors-smart}"/> >> >> >> > <include name="${lib.dir}/${apache-bsf.jar}"/> >> >> >> > + <include name="${lib.dir}/${asm.jar}"/> >> >> >> > <include name="${lib.dir}/${avalon-framework.jar}"/> >> >> >> > <include name="${lib.dir}/${beanshell.jar}"/> >> >> >> > <include name="${lib.dir}/${commons-codec.jar}"/> >> >> >> > @@ -432,7 +434,9 @@ >> >> >> > <!-- Build classpath (includes the optional jar directory) --> >> >> >> > <path id="classpath"> >> >> >> > <!-- Externally produced jars --> >> >> >> > + <pathelement location="${lib.dir}/${accessors-smart.jar}"/> >> >> >> > <pathelement location="${lib.dir}/${apache-bsf.jar}"/> >> >> >> > + <pathelement location="${lib.dir}/${asm.jar}"/> >> >> >> > <pathelement location="${lib.dir}/${avalon-framework.jar}"/> >> >> >> > <pathelement location="${lib.dir}/${beanshell.jar}"/> >> >> >> > <pathelement location="${lib.dir}/${commons-codec.jar}"/> >> >> >> > @@ -2848,7 +2852,9 @@ run JMeter unless all the JMeter jars ar >> >> >> > conditional execution (it would be a lot easier if antcall >> >> >> supported if/unless). >> >> >> > --> >> >> >> > <target name="_process_all_jars"> >> >> >> > - <process_jarfile jarname="apache-bsf"/> >> >> >> > + <process_jarfile jarname="accessors-smart"/> >> >> >> > + <process_jarfile jarname="apache-bsf"/> >> >> >> > + <process_jarfile jarname="asm"/> >> >> >> > <process_jarfile jarname="avalon-framework"/> >> >> >> > <process_jarfile jarname="bcmail" dest.dir="${lib.api}"/> >> >> >> > <process_jarfile jarname="bcprov" dest.dir="${lib.api}"/> >> >> >> > >> >> >> > Modified: jmeter/trunk/eclipse.classpath >> >> >> > URL: >> >> >> >> >> >> http://svn.apache.org/viewvc/jmeter/trunk/eclipse.classpath?rev=1735407&r1=1735406&r2=1735407&view=diff >> >> >> > >> >> >> >> >> >> ============================================================================== >> >> >> > --- jmeter/trunk/eclipse.classpath (original) >> >> >> > +++ jmeter/trunk/eclipse.classpath Thu Mar 17 12:14:44 2016 >> >> >> > @@ -43,6 +43,8 @@ >> >> >> > <classpathentry kind="src" output="build/protocol/native" >> >> >> path="src/protocol/native"/> >> >> >> > <classpathentry kind="src" output="build/protocol/tcp" >> >> >> path="src/protocol/tcp"/> >> >> >> > <classpathentry kind="src" output="build/test" >> >> path="test/src"/> >> >> >> > + <classpathentry kind="lib" >> path="lib/accessors-smart-1.1.jar"/> >> >> >> > + <classpathentry kind="lib" path="lib/asm-5.1.jar"/> >> >> >> > <classpathentry kind="lib" >> >> >> path="lib/avalon-framework-4.1.4.jar"/> >> >> >> > <classpathentry kind="lib" path="lib/bsf-2.4.0.jar"/> >> >> >> > <classpathentry kind="lib" path="lib/bsh-2.0b5.jar"/> >> >> >> > >> >> >> > Propchange: jmeter/trunk/lib/ >> >> >> > >> >> >> >> >> >> ------------------------------------------------------------------------------ >> >> >> > --- svn:ignore (original) >> >> >> > +++ svn:ignore Thu Mar 17 12:14:44 2016 >> >> >> > @@ -1,5 +1,7 @@ >> >> >> > ext >> >> >> > src >> >> >> > +accessors-smart-1.1.jar >> >> >> > +asm-5.1.jar >> >> >> > avalon-framework-4.1.4.jar >> >> >> > bsf-2.4.0.jar >> >> >> > bsh-2.0b5.jar >> >> >> > >> >> >> > Modified: jmeter/trunk/lib/aareadme.txt >> >> >> > URL: >> >> >> >> >> >> http://svn.apache.org/viewvc/jmeter/trunk/lib/aareadme.txt?rev=1735407&r1=1735406&r2=1735407&view=diff >> >> >> > >> >> >> >> >> >> ============================================================================== >> >> >> > --- jmeter/trunk/lib/aareadme.txt (original) >> >> >> > +++ jmeter/trunk/lib/aareadme.txt Thu Mar 17 12:14:44 2016 >> >> >> > @@ -13,6 +13,14 @@ Which jars are used by which modules? >> >> >> > ==================================== >> >> >> > [not exhaustive] >> >> >> > >> >> >> > +asm-5.1 (org.ow2.asm) >> >> >> > +---------------------- >> >> >> > +- JSON Path extractor >> >> >> > + >> >> >> > +accessors-smart-1.1 (net.minidev) >> >> >> > +---------------------- >> >> >> > +- JSON Path extractor >> >> >> > + >> >> >> > avalon-framework-4.1.4 (org.apache.avalon.framework) >> >> >> > ---------------------- >> >> >> > - LogKit (LoggingManager) >> >> >> > @@ -144,7 +152,7 @@ https://github.com/jayway/JsonPath >> >> >> > - JSON Path Extractor >> >> >> > - JSON Path Renderer >> >> >> > >> >> >> > -json-smart-2.2.1 >> >> >> > +json-smart-2.2.1 (net.minidev) >> >> >> > -------- >> >> >> > https://github.com/netplex/json-smart-v2 >> >> >> > - JSON Path Extractor >> >> >> > >> >> >> > Modified: jmeter/trunk/res/maven/ApacheJMeter_parent.pom >> >> >> > URL: >> >> >> >> >> >> http://svn.apache.org/viewvc/jmeter/trunk/res/maven/ApacheJMeter_parent.pom?rev=1735407&r1=1735406&r2=1735407&view=diff >> >> >> > >> >> >> >> >> >> ============================================================================== >> >> >> > --- jmeter/trunk/res/maven/ApacheJMeter_parent.pom (original) >> >> >> > +++ jmeter/trunk/res/maven/ApacheJMeter_parent.pom Thu Mar 17 >> 12:14:44 >> >> >> 2016 >> >> >> > @@ -52,7 +52,9 @@ under the License. >> >> >> > >> >> >> > <properties> >> >> >> > <!-- these must agree with the definitions in >> build.properties >> >> --> >> >> >> > + <accessors-smart.version>1.1</accessors-smart.version> >> >> >> > <apache-bsf.version>2.4.0</apache-bsf.version> >> >> >> > + <asm.version>5.1</asm.version> >> >> >> > <avalon-framework.version>4.1.4</avalon-framework.version> >> >> >> > <beanshell.version>2.0b5</beanshell.version> >> >> >> > <bcmail.version>1.49</bcmail.version> >> >> >> > @@ -109,6 +111,16 @@ under the License. >> >> >> > >> >> >> > <dependencies> >> >> >> > <dependency> >> >> >> > + <groupId>org.ow2.asm</groupId> >> >> >> > + <artifactId>asm</artifactId> >> >> >> > + <version>${asm.version}</version> >> >> >> > + </dependency> >> >> >> > + <dependency> >> >> >> > + <groupId>net.minidev</groupId> >> >> >> > + <artifactId>accessors-smart</artifactId> >> >> >> > + <version>${accessors-smart.version}</version> >> >> >> > + </dependency> >> >> >> > + <dependency> >> >> >> > <groupId>bsf</groupId> >> >> >> > <artifactId>bsf</artifactId> >> >> >> > <version>${apache-bsf.version}</version> >> >> >> > >> >> >> > Modified: jmeter/trunk/xdocs/changes.xml >> >> >> > URL: >> >> >> >> >> >> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1735407&r1=1735406&r2=1735407&view=diff >> >> >> > >> >> >> >> >> >> ============================================================================== >> >> >> > --- jmeter/trunk/xdocs/changes.xml (original) >> >> >> > +++ jmeter/trunk/xdocs/changes.xml Thu Mar 17 12:14:44 2016 >> >> >> > @@ -373,6 +373,7 @@ Summary >> >> >> > <ul> >> >> >> > <li><bug>58079</bug>Do not cache HTTP samples that have a Vary >> header >> >> >> when using a HTTP CacheManager.</li> >> >> >> > <li><bug>58912</bug>Response assertion gui : Deleting more than 1 >> >> >> selected row deletes only one row. Contributed by Benoit Wiart >> (benoit >> >> dot >> >> >> wiart at gmail.com)</li> >> >> >> > +<li><bug>59187</bug>JSON Post Processor : >> >> >> java.lang.NoClassDefFoundError: net/minidev/asm/FieldFilter at >> >> >> net.minidev.json.reader.JsonWriter.(JsonWriter.java:157) (affects >> >> nightly >> >> >> build before 3.0 release)</li> >> >> >> > </ul> >> >> >> > >> >> >> > <h3>Functions</h3> >> >> >> > >> >> >> > >> >> >> >> >> > >> >> > >> >> > >> >> > -- >> >> > Cordialement. >> >> > Philippe Mouawad. >> >> >> > >> > >> > >> > -- >> > Cordialement. >> > Philippe Mouawad. >> > > > > -- > Cordialement. > Philippe Mouawad.
