What is the preferred way of commenting on the line-by-line basis?
I'm not used to comment on patch files.
How do you do that?
>+ log.warn(getName()+":applying OUTOFMEMORY PROTECTION, SampleResults are not
>added anymore, use NON-GUI mode"
>+ + " or configure property 'view.results.tree.max_nodes'");
Should it log only once? It looks like it would log for each new result.
> serialVersionUID
Technically speaking, serialVersionUID bump is not required for
TableVisualizer. Is it?
>+ private AtomicLong currentSizeApproximation = new AtomicLong(0l);
What is that?
> + /**
>+ * When the limit is reached, JMeter will not {@link SampleResult} anymore
>+ * Setting to 0 disables the protection
>+ */
>+ private boolean applyOOMProtection() {
javadoc is weird. Especially, "setting to 0" part of ti.
Vladimir
