On 16/11/2016 07:24, Philippe Mouawad wrote:
On Wed, Nov 16, 2016 at 8:12 AM, Milamber <[email protected]> wrote:


On 16/11/2016 06:55, Philippe Mouawad wrote:

Hi,
Shall I commit the patch slightly modified as brotli is not managed by HC
?
Or do we release 3.1 before.

The original issue (JMeter don't record if the deflate algo is used) are
fixed by your patch? in others words: the issue was the miscalculated of
the content-length?

Yes


@milamber, if I commit it this morning, what's your timeline for next RC?

If the RC3 vote is cancelled today, I can produce a new RC tonight I think.
I just afraid with a new RC and the discovery of a new blocker issue after
by someone. I thinks we must do better tests for each RC to find maximum of
bugs before the next RC. Currently, the cycle is: RC->1 blocker->RC->1
blocker->RC, etc. I will prefer: RC->a lot of blockers->RC->release ;-)

Frankly Milamber this issue could not have been detected as it exists since
a lot of versions.
There was only really 1 blocker on 3.1 code discovered by Felix.
The RC1 was a no version, RC2 had a blocker, RC3 here could be released but
I think for users it's better to wait 3 more days than 3 to 6 months.

I will wait tonight if another bugs are found before cancel the vote.
You can commit the fix, (and add a Junit test?)



Of course more tests are welcome by everybody :-) And ideally more coverage
.
For example for this issue we would need to develop a JUnit test



Milamber


Thanks

On Tuesday, November 15, 2016, Philippe Mouawad <
[email protected]>
wrote:

Hi,
I think there is really a bug anyway since we transmit a wrong
Content-Length.
We currently recompute it for GZIP , so we should for Deflate and Brotli
or whatever compressed content.

By the way do you know if HttpClient/HttpCore handles Brotli compression
?

Regards
Philippe

On Tue, Nov 15, 2016 at 8:38 PM, Philippe Mouawad <
[email protected]
<javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:

Hello,
I tried it and I am not able to reproduce it on many websites.
But it occurs on this one.
I'll attach headers to Bugzilla but I'll change host

Regards

On Tue, Nov 15, 2016 at 7:22 PM, Milamber <[email protected]
<javascript:_e(%7B%7D,'cvml','[email protected]');>> wrote:

I don't found this issue with JMeter 3.1? (with my blog website and
Firefox) Can you provide the request header and the response header?



On 15/11/2016 17:01, Philippe Mouawad wrote:

Hello,
I have found a bug which affects Test Script recorder and application
using
Deflate encoding :
https://bz.apache.org/bugzilla/show_bug.cgi?id=60376

It was not introduced in 3.1 but it is pretty nasty IMO and I would
like it
to be fixed before 3.1.
It seems JMeter was  never able to record applications using Deflate
encoding , which seems strange to me, I tested 2.13 and 3.0 and they
are
affected.

I have the fix working, I will commit it this evening.

What's your thoughts on this ?

Regards
Philippe M.

On Mon, Nov 14, 2016 at 9:05 PM, Antonio Gomes Rodrigues <
[email protected] <javascript:_e(%7B%7D,'cvml','[email protected]');>>
wrote:

Hi,

Tested in Windows 10 and linux fedora 24

+1

Regards,
Antonio

2016-11-14 12:44 GMT+01:00 Felix Schumacher <
[email protected]
<javascript:_e(%7B%7D,'cvml','[email protected]
');>>:


Am 13. November 2016 20:34:16 MEZ, schrieb Milamber <
[email protected]
<javascript:_e(%7B%7D,'cvml','[email protected]');>

:

Hello,
The third release candidate for JMeter 3.1 (r1769531) has been
prepared,
and your votes are solicited.

This release brings new features and fixes bugs.

Please, test this release candidate (with load tests and/or
functional
tests) using Java 7/8 on Linux/Windows/Mac OS, especially on the
changes. The feedback are welcome.

You can read the New and Noteworthy section with some screenshots
to
illustrate improvements and full list of changes at:
http://home.apache.org/~milamber/jmeter-3.1RC3/docs/changes.html

JMeter is a Java desktop application designed to load test
functional
behavior and measure performance. The current version is targeted
at
Java 7+.

Download - Archives/hashes/sigs:

https://dist.apache.org/repos/dist/dev/jmeter/v3.1_RC3/
(dist revision r16985)

RAT report:

http://home.apache.org/~milamber/jmeter-3.1RC3/dist/

rat-report-jmeter-3.1RC3.txt
MD5 hashes of archives for this vote:
37e3c75cf80d2c60444e429bb0c27ae6 *apache-jmeter-3.1.tgz
f096f4991454a22850ec6174331cfeed *apache-jmeter-3.1.zip
a3e308d541a6c077ec322bce0d699a77 *apache-jmeter-3.1_src.tgz
96b94f4e0189bd0aa6e578e80323e6b7 *apache-jmeter-3.1_src.zip

Site Docs are here:
http://home.apache.org/~milamber/jmeter-3.1RC3/docs/

Maven staging repository is accessible here:
https://repository.apache.org/content/repositories/

orgapachejmeter-1013/org/apache/jmeter/
Tag:
https://svn.apache.org/repos/asf/jmeter/tags/v3_1_RC3/

Keys are here:
https://www.apache.org/dist/jmeter/KEYS

N.B.
To download the dependencies: "ant download_jars"

To create the jars and test JMeter: "ant package test".

JMeter 3.1 requires Java 7 or later to run.

Some known issues and incompatible changes are listed on changes
page.
http://home.apache.org/~milamber/jmeter-3.1RC3/docs/

changes.html#Known%20problems%20and%20workarounds
All feedback and vote are welcome.
[x] +1  I support this release
[  ] +0  I am OK with this release
[  ] -0   OK, but....
[  ] -1   I do not support this release (please indicate why)

The vote will remain open for at least 72 hours.

The PMC members please indicate the mention "(binding)" with your
vote.

+1
Regards,
     Felix (binding)


Note: If the vote passes, the intention is to release the archive
files
and rename the RC tag as the release tag.

Thanks in advance!

Milamber


--
Cordialement.
Philippe Mouawad.




--
Cordialement.
Philippe Mouawad.






Reply via email to