Github user FSchumacher commented on a diff in the pull request:
https://github.com/apache/jmeter/pull/237#discussion_r91858293
--- Diff:
src/components/org/apache/jmeter/visualizers/backend/SamplerMetric.java ---
@@ -28,24 +34,39 @@
* @since 2.13
*/
public class SamplerMetric {
- private static final int SLIDING_WINDOW_SIZE =
JMeterUtils.getPropDefault("backend_metrics_window", 100); //$NON-NLS-1$
// Response times for OK samples
- // Limit to sliding window of SLIDING_WINDOW_SIZE values
- private DescriptiveStatistics okResponsesStats = new
DescriptiveStatistics(SLIDING_WINDOW_SIZE);
+ private DescriptiveStatistics okResponsesStats = new
DescriptiveStatistics();
// Response times for KO samples
- // Limit to sliding window of SLIDING_WINDOW_SIZE values
- private DescriptiveStatistics koResponsesStats = new
DescriptiveStatistics(SLIDING_WINDOW_SIZE);
+ private DescriptiveStatistics koResponsesStats = new
DescriptiveStatistics();
// Response times for All samples
- // Limit to sliding window of SLIDING_WINDOW_SIZE values
- private DescriptiveStatistics allResponsesStats = new
DescriptiveStatistics(SLIDING_WINDOW_SIZE);
+ private DescriptiveStatistics allResponsesStats = new
DescriptiveStatistics();
+ // OK, KO, ALL stats
+ private List<DescriptiveStatistics> windowedStats =
Collections.emptyList();
+ // Timeboxed percentiles don't makes sense
+ private DescriptiveStatistics pctResponseStats = new
DescriptiveStatistics();
+ private WindowMode windowMode;
private int successes;
private int failures;
private int hits;
/**
*
*/
public SamplerMetric() {
+ windowMode = WindowMode.get();
+
+ List<DescriptiveStatistics> stats = new ArrayList<>();
+ stats.add(pctResponseStats);
+ if (windowMode == WindowMode.FIXED) {
+ windowedStats = asList(okResponsesStats,
koResponsesStats, allResponsesStats);
+ stats.addAll(windowedStats);
+ }
+
+ int slidingWindowSize =
JMeterUtils.getPropDefault("backend_metrics_window", 100);
+ // Limit to sliding window of SLIDING_WINDOW_SIZE values
+ for (DescriptiveStatistics stat : stats) {
--- End diff --
Formatting issue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
