Github user Wyatts commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/238#discussion_r92001179
  
    --- Diff: src/core/org/apache/jmeter/threads/AbstractThreadGroup.java ---
    @@ -251,6 +251,8 @@ public boolean getOnErrorStopTestNow() {
     
         public abstract void start(int groupCount, ListenerNotifier notifier, 
ListedHashTree threadGroupTree, StandardJMeterEngine engine);
     
    +    public abstract void addNewThread(int delay, StandardJMeterEngine 
engine);
    --- End diff --
    
    Is it possible that, rather than void, this could return... say, the 
threadId?  Having the option to keep track of the threads you've started in 
this manner would be useful if, for example, you want to remove them (because 
removing a thread requires that threadId).  The alternative is making a 
comparable removeOldThread() method to complete the API, but I'm sort of up in 
the air on whether it would be a good idea to grab a random thread and tell it 
to end in current JMeter (it makes perfect sense in a hypothetical future 
dispatch-oriented design, though).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to