>On managersInUse we use
>wait() and notify(), which seems wrong to me, as we synchronized using
>LOCK and not managersInUse.

Is that code used at all?

It looks like the code in [1] must throw (the same regarding .wait() code
below)

IllegalMonitorStateException  if the current thread is not
*               the owner of this object's monitor


By the way, [2] should re-interrupt and terminate the loop. For instance,
if user clicks stop, then this while(managersInUse.contains(cm)) should get
terminated instead of retrying again and again.

[1]:
https://github.com/apache/jmeter/blob/1139c450e33c136abaa9640804839ba02760f844/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/SessionFilter.java#L167
[2]:
https://github.com/apache/jmeter/blob/1139c450e33c136abaa9640804839ba02760f844/src/protocol/http/org/apache/jmeter/protocol/http/util/accesslog/SessionFilter.java#L191-L193


Vladimir

Reply via email to