Github user woonsan commented on the issue:
https://github.com/apache/jmeter/pull/254
@pmouawad , thanks a lot for the quick review!
Regarding NewDriver#replaceDateFormatInFileName(), here's the reason why I
added that:
- As LoggingManager#makeWriter() was gone
(https://github.com/apache/jmeter/blob/trunk/src/jorphan/org/apache/jorphan/logging/LoggingManager.java#L174),
I needed to have the same feature somewhere else to keep the backward
compatibility for the log file name option with date format
(http://jmeter.apache.org/usermanual/get-started.html#options)
- However, the date format in the log file name option has been broken for
long time in my understanding. For example, if I pass
"jmeter_'yyyyMMddHHmmss'.log" option value, it simply fails because
SimpleDateFormat complains about unrecognized format character, 'j', for
instance.
- Therefore, I rewrote the LoggingManager#makeWriter() method in
NewDriver#replaceDateFormatInFileName() in order to extract string inside
single quote pair and format / append the value using SimpleDateFormat, not the
whole (which leads formatting failure always, resulting log file name option
used literally, not evaluated with current date).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
